From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v4] pm_ops: add system quiesce/activate hooks Date: Sat, 14 Apr 2007 08:24:10 +1000 Message-ID: <1176503050.5764.107.camel@localhost.localdomain> References: <1175810054.3489.34.camel@johannes.berg> <200704131347.30001.rjw@sisk.pl> <1176470819.7052.108.camel@johannes.berg> <200704132243.59618.rjw@sisk.pl> <20070413205837.GG28264@elf.ucw.cz> <1176498368.7052.117.camel@johannes.berg> <20070413211232.GJ28264@elf.ucw.cz> <1176499130.5764.94.camel@localhost.localdomain> <20070413215609.GP28264@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070413215609.GP28264@elf.ucw.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Pavel Machek Cc: Johannes Berg , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org > There are about 7 places where we do stop_platform_devices() > local_irq_disable() stop_sysdevs(). You call your hook from one of > them and I suspect you need to call it from more than one. Plus, the > hook needs to have documented semantics, so people know if they should > do local_irq_disable() or if they should call your hook. The simple fact that these sequence is copied in 7 different places is a pretty good illustration of what's wrong with the core pm code ... Ben.