From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-pm@lists.linux-foundation.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v4] pm_ops: add system quiesce/activate hooks
Date: Sun, 15 Apr 2007 10:19:42 +1000 [thread overview]
Message-ID: <1176596382.10629.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1176542370.7052.159.camel@johannes.berg>
> On the other hand, if doing an arch hook here and something like
> CONFIG_ARCH_HAS_SUSPEND_IRQ_HOOKS would actually allow us to end this
> pointless discussion, then why not.
The preferred approach for that sort of thing nowadays is to have
the generic code contain
#ifndef arch_foo_bar()
#define arch_foo_bar() do { } while(0)
#endif
And have the arch code do
void arch_foo_bar(void)
{
xxx
}
#define arch_foo_bar arch_foo_bar
Ben.
next prev parent reply other threads:[~2007-04-15 0:19 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 21:54 [PATCH] pm_ops: add irq enable/disable hooks Johannes Berg
2007-04-05 23:30 ` Rafael J. Wysocki
2007-04-05 23:28 ` Johannes Berg
2007-04-06 0:02 ` Rafael J. Wysocki
2007-04-06 0:09 ` Johannes Berg
2007-04-06 0:17 ` Rafael J. Wysocki
2007-04-06 8:48 ` Johannes Berg
2007-04-06 9:41 ` Rafael J. Wysocki
2007-04-06 9:44 ` Johannes Berg
2007-04-06 10:02 ` Rafael J. Wysocki
2007-04-06 10:00 ` Johannes Berg
2007-04-06 19:19 ` Pavel Machek
2007-04-06 21:59 ` Johannes Berg
2007-04-10 11:36 ` Pavel Machek
2007-04-10 11:45 ` Johannes Berg
2007-04-10 12:00 ` Pavel Machek
2007-04-10 13:42 ` Johannes Berg
2007-04-11 11:22 ` Benjamin Herrenschmidt
2007-04-11 14:07 ` Alan Stern
2007-04-11 16:39 ` Johannes Berg
2007-04-11 21:40 ` Benjamin Herrenschmidt
2007-04-11 11:15 ` Johannes Berg
2007-04-06 19:16 ` Pavel Machek
2007-04-11 15:54 ` [PATCH v2] pm_ops: add system quiesce/activate hooks Johannes Berg
2007-04-11 20:47 ` Dmitry Krivoschekov
2007-04-12 8:39 ` Johannes Berg
2007-04-12 8:42 ` Benjamin Herrenschmidt
2007-04-12 10:16 ` Pavel Machek
2007-04-12 10:45 ` Rafael J. Wysocki
2007-04-12 10:47 ` Johannes Berg
2007-04-13 21:00 ` Pavel Machek
2007-04-13 21:11 ` Johannes Berg
2007-04-13 21:43 ` Pavel Machek
2007-04-13 21:11 ` Paul Mackerras
2007-04-13 21:15 ` Benjamin Herrenschmidt
2007-04-12 11:23 ` Benjamin Herrenschmidt
2007-04-12 15:03 ` Rafael J. Wysocki
2007-04-12 16:32 ` David Brownell
2007-04-13 6:52 ` Johannes Berg
2007-04-13 7:59 ` [PATCH v3] " Johannes Berg
2007-04-12 17:36 ` [PATCH v2] " Dmitry Krivoschekov
2007-04-12 20:51 ` Benjamin Herrenschmidt
2007-04-13 6:54 ` Johannes Berg
2007-04-13 8:04 ` David Brownell
2007-04-13 8:59 ` Johannes Berg
2007-04-13 9:07 ` Benjamin Herrenschmidt
2007-04-13 11:47 ` Rafael J. Wysocki
2007-04-13 12:58 ` Johannes Berg
2007-04-13 13:26 ` [PATCH v4] " Johannes Berg
2007-04-13 20:43 ` Rafael J. Wysocki
2007-04-13 20:58 ` Pavel Machek
2007-04-13 21:06 ` Johannes Berg
2007-04-13 21:12 ` Pavel Machek
2007-04-13 21:18 ` Johannes Berg
2007-04-13 21:33 ` Pavel Machek
2007-04-13 21:45 ` Johannes Berg
2007-04-13 21:52 ` Pavel Machek
2007-04-13 21:59 ` Johannes Berg
2007-04-13 22:18 ` Rafael J. Wysocki
2007-04-13 22:20 ` Johannes Berg
2007-04-13 22:49 ` Rafael J. Wysocki
2007-04-13 22:55 ` Johannes Berg
2007-04-13 22:09 ` Rafael J. Wysocki
2007-04-13 22:13 ` Johannes Berg
2007-04-13 22:16 ` Pavel Machek
2007-04-14 16:55 ` Paul Mackerras
2007-04-13 22:25 ` Benjamin Herrenschmidt
2007-04-13 22:39 ` Pavel Machek
2007-04-13 23:19 ` Benjamin Herrenschmidt
2007-04-14 9:14 ` Rafael J. Wysocki
2007-04-14 9:19 ` Johannes Berg
2007-04-15 0:19 ` Benjamin Herrenschmidt [this message]
2007-04-16 7:32 ` Pavel Machek
2007-04-16 8:37 ` Johannes Berg
2007-04-16 12:47 ` Pavel Machek
2007-04-17 4:58 ` Paul Mackerras
2007-04-18 7:50 ` Benjamin Herrenschmidt
2007-04-13 22:47 ` Rafael J. Wysocki
2007-04-13 21:18 ` Benjamin Herrenschmidt
2007-04-13 21:56 ` Pavel Machek
2007-04-13 22:01 ` Johannes Berg
2007-04-13 22:24 ` Benjamin Herrenschmidt
2007-04-13 21:15 ` Benjamin Herrenschmidt
2007-04-13 21:50 ` Pavel Machek
2007-04-13 22:23 ` Benjamin Herrenschmidt
2007-04-14 22:10 ` David Brownell
2007-04-13 21:05 ` [PATCH v2] " Pavel Machek
2007-04-12 8:44 ` Benjamin Herrenschmidt
2007-04-17 17:18 ` [PATCH] s2ram: add arch irq disable/enable hooks Johannes Berg
2007-04-18 11:27 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176596382.10629.1.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox