Re: [PATCH] s2ram: add arch irq disable/enable hooks

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1.1: Type: text/plain, Size: 938 bytes --]

On Sun, 2007-04-22 at 13:13 +0000, Pavel Machek wrote:

> > This is a very straightforward point.  A function that's
> > called on non-S2RAM paths shouldn't be named as if it's
> > only for S2RAM.
> 
> And the function that's called for s2ram+standby should not be named
> as if it's also for swsusp...
> 
> > Ergo, those two functions are misnamed.  End of story.
> 
> ...which is not only misnamed, it is also actively confusing. (And
> someone _will_ ask me to call that function from swsusp, too.
> 
> ...maybe we could solve it with a big fat comment?

So how about we don't call them s2ram which is confusing since s2ram is
only one suspend state we support but call them suspend as David
originally proposed and add a comment that since suspend-to-disk isn't a
true suspend state, they are not called there?

Has anybody figured out if (and if yes, where) we should add them to
some header file?

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]