Re: [RFC/PATCH 1/2] swsusp: preserve boot-time printk output after resume

[Nigel Cunningham <nigel@nigel.suspend2.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]

Hi.

On Sat, 2007-04-28 at 00:05 +0200, Pavel Machek wrote:
> On Sat 2007-04-28 07:21:59, Nigel Cunningham wrote:
> > Hi.
> > 
> > On Fri, 2007-04-27 at 14:57 +0200, Pavel Machek wrote:
> > > On Fri 2007-04-27 15:52:12, Pekka J Enberg wrote:
> > > > On Fri, 27 Apr 2007, Pavel Machek wrote:
> > > > > 1. This should not be a config option
> > > > 
> > > > Ok.
> > > 
> > > Unfortunately, we loose dmesg from the state saving this way, so I do
> > > not think it can be hardcoded, either. Best way would be to somehow
> > > preserve both dmesg buffers.
> > > 
> > > Other way is to just control it by the define in the .c file; person
> > > using this is by definition kernel hacker, anyway. Or this can simply
> > > live like debugging patch, interested parties can apply.
> > 
> > That's why I made it a config option - so you can choose whether you
> > want it or not.
> 
> Yes, and having it as a config option is completely wrong. There's no
> good value for that config option, how is poor user going to answer
> it. That config option is evil.

It's an option for developers, and what's appropriate depends on which
part of the resume you're trying to debug. That said, I do agree that
preserving both buffers would be nicer.

Nigel

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]