From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] Remove process freezer from suspend to RAM pathway Date: Sun, 08 Jul 2007 14:39:36 +1000 Message-ID: <1183869576.3388.250.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: Matthew Garrett , linux-kernel@vger.kernel.org, Kyle Moffett , Pavel Machek , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org > In my defense, you should realize that until Rafael's notifier chain > was added (just a few weeks ago, still not in mainline I believe) there > was no other way to do it. Plug activity needs to be stopped before > the child devices are suspended, and the PM core does not send any > notification to drivers at that time. All it does is activate the > freezer. That's true. That was one of the reason I've always wanted the pre-suspend and post-resume hooks. (I prefer keeping the ordering there too, rather than a notifier, but a notifier is fine I suppose). Among the clients we want here the firmware stuff, the allocators, etc... to get themselves in conditions that won't deadlock during suspend cycle. I think that's a much bigger issue overall than freezer vs. no freezer :-) Ben.