From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Pavel@smtp2.linux-foundation.org, Andi Kleen <ak@suse.de>
Subject: Re: Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
Date: Sat, 25 Aug 2007 21:13:45 +0200 [thread overview]
Message-ID: <1188069225.9529.23.camel@johannes.berg> (raw)
In-Reply-To: <20070824162346.ec57f508.akpm@linux-foundation.org>
[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]
On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote:
> The preferred way of doing this is via Kconfig, please. ie: add a
> CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig.
> It would be better to do something like this in (say) suspend.h:
>
> #ifdef CONFIG_HIBERNATION_HEADER
> extern int arch_hibernation_header_save(void *addr, unsigned int max_size);
> extern int arch_hibernation_header_restore(void *addr);
> #else
> static inline int arch_hibernation_header_save(void *addr,
In fact, I guess we don't need to bother with this at all. The generic
code for doing this (via the utsname based header) is tiny, so as far as
I can tell it could just be made weak symbols (by this I mean
init_header_complete() and check_image_kernel()), and then all the
#ifdefs can just go.
johannes
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2007-08-25 19:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200708241206.57178.rjw@sisk.pl>
2007-08-24 10:09 ` [PATCH -mm 1/2] Hibernation: Arbitrary boot kernel support - generic code Rafael J. Wysocki
2007-08-24 10:11 ` [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64 Rafael J. Wysocki
2007-08-24 10:59 ` Johannes Berg
[not found] ` <1187953143.24933.17.camel@johannes.berg>
2007-08-24 13:11 ` Rafael J. Wysocki
2007-08-24 20:46 ` Pavel Machek
2007-08-24 23:23 ` Andrew Morton
2007-08-25 19:13 ` Johannes Berg [this message]
2007-08-27 11:06 ` Rafael J. Wysocki
[not found] ` <200708271306.46778.rjw@sisk.pl>
2007-08-27 11:09 ` Johannes Berg
2007-08-27 11:12 ` Rafael J. Wysocki
2007-08-25 20:32 ` Rafael J. Wysocki
[not found] ` <20070824204632.GA5008@ucw.cz>
2007-08-25 18:27 ` Rafael J. Wysocki
2007-08-25 18:32 ` david
2007-08-25 19:51 ` Rafael J. Wysocki
2007-08-25 20:42 ` [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64 (updated) Rafael J. Wysocki
2007-08-27 8:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188069225.9529.23.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Pavel@smtp2.linux-foundation.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox