Re: [RFC] powermac: proper sleep management

Benjamin Herrenschmidt
2007-11-08T23:19:16Z

On Thu, 2007-11-08 at 13:15 -0600, Scott Wood wrote:
> Johannes Berg wrote:
> > +/*
> > + * overrides the weak arch_suspend_disable_irqs in kernel/power/main.c
> > + *
> > + * XXX: Once Scott Wood's patch is merged, this needs to use the ppc_md
> > + * hooks that patch adds!
> > + */
> > +void arch_suspend_disable_irqs(void)
> > +{
> > +#ifdef CONFIG_PMAC_BACKLIGHT
> > + /* Tell backlight code not to muck around with the chip anymore */
> > + pmu_backlight_set_sleep(1);
> > +#endif
> > +
> > + /* Call platform functions marked "on sleep" */
> > + pmac_pfunc_i2c_suspend();
> > + pmac_pfunc_base_suspend();
>
> Shouldn't these be done from suspend methods of the relevant drivers?
> I don't understand why this needs to go in the disable IRQ hook.

The pmac_pfunc thing is low level platform stuff, no driver involved
there, this is the right place to do it.

As for the backlight bits, that could indeed be moved around I suppose,
I'd keep it there for now and look at cleaning the PMU driver
suspend/resume path in a second step.

Ben.