From: Johannes Berg <johannes@sipsolutions.net>
To: Len Brown <len.brown@intel.com>
Cc: linux-pm <linux-pm@lists.linux-foundation.org>
Subject: [PATCH] PM: make freezer optional for suspend
Date: Tue, 13 Nov 2007 20:04:30 +0100 [thread overview]
Message-ID: <1194980670.6695.1.camel@johannes.berg> (raw)
This patch makes the freezer optional for suspend to allow the
system to work (or not work) like the original PMU suspend.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
In a quick test, playing sound across suspend failed to work,
it usually works when the freezer is enabled (unless you use
gstreamer.)
kernel/power/Kconfig | 10 ++++++++++
kernel/power/main.c | 6 ++++++
2 files changed, 16 insertions(+)
--- everything.orig/kernel/power/main.c 2007-11-13 20:00:16.406263508 +0100
+++ everything/kernel/power/main.c 2007-11-13 20:00:17.626268174 +0100
@@ -79,10 +79,12 @@ static int suspend_prepare(void)
pm_prepare_console();
+#ifdef CONFIG_SUSPEND_FREEZER
if (freeze_processes()) {
error = -EAGAIN;
goto Thaw;
}
+#endif
free_pages = global_page_state(NR_FREE_PAGES);
if (free_pages < FREE_PAGE_NUMBER) {
@@ -96,8 +98,10 @@ static int suspend_prepare(void)
if (!error)
return 0;
+#ifdef CONFIG_SUSPEND_FREEZER
Thaw:
thaw_processes();
+#endif
pm_restore_console();
Finish:
pm_notifier_call_chain(PM_POST_SUSPEND);
@@ -191,7 +195,9 @@ int suspend_devices_and_enter(suspend_st
*/
static void suspend_finish(void)
{
+#ifdef CONFIG_SUSPEND_FREEZER
thaw_processes();
+#endif
pm_restore_console();
pm_notifier_call_chain(PM_POST_SUSPEND);
}
--- everything.orig/kernel/power/Kconfig 2007-11-13 20:00:16.476274685 +0100
+++ everything/kernel/power/Kconfig 2007-11-13 20:01:10.186257269 +0100
@@ -97,6 +97,16 @@ config SUSPEND
powered and thus its contents are preserved, such as the
suspend-to-RAM state (i.e. the ACPI S3 state).
+config SUSPEND_FREEZER
+ bool "Enable freezer for suspend to RAM/standby" if ADB_PMU || BROKEN
+ depends on SUSPEND
+ default y
+ help
+ This allows you to turn off the freezer for suspend. If this is
+ done, no tasks are frozen for suspend to RAM/standby.
+
+ Turning OFF this setting is NOT recommended! If in doubt, say Y.
+
config HIBERNATION_UP_POSSIBLE
bool
depends on X86 || PPC64_SWSUSP || PPC32
next reply other threads:[~2007-11-13 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 19:04 Johannes Berg [this message]
2007-11-14 13:21 ` [PATCH] PM: make freezer optional for suspend Rafael J. Wysocki
2007-11-14 14:38 ` Johannes Berg
2007-11-14 21:30 ` Rafael J. Wysocki
2007-11-15 16:47 ` Johannes Berg
2007-11-15 20:24 ` Rafael J. Wysocki
2007-11-16 15:58 ` Johannes Berg
2007-11-18 18:21 ` Pavel Machek
2007-11-19 14:40 ` Johannes Berg
2007-11-19 16:25 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194980670.6695.1.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=len.brown@intel.com \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox