From: Johannes Berg <johannes@sipsolutions.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm <linux-pm@lists.linux-foundation.org>,
Jamey Hicks <jamey@crl.dec.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [RFC] apm-emulation: implement notify/ack for /sys/power/state events
Date: Sun, 16 Dec 2007 19:59:11 +0100 [thread overview]
Message-ID: <1197831551.6769.13.camel@johannes.berg> (raw)
In-Reply-To: <200712162015.59963.rjw@sisk.pl>
[-- Attachment #1.1: Type: text/plain, Size: 466 bytes --]
> Yes, I think it should go through the suspend tree, so that we can avoid adding
> this export. It would be confusing otherwise.
Yes, but I think it's a fix for a regression on 2.6.24, so benh may want
to get it in there.
> > + * FIXME: is the suspends_pending == 1 test racy?
>
> Make suspends_pending atomic? Then, you'd not need the locking around it.
Yeah, I guess that's the best way to handle it. I'll send an updated
patch.
johannes
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2007-12-16 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 17:58 [RFC] apm-emulation: implement notify/ack for /sys/power/state events Johannes Berg
2007-12-16 19:15 ` Rafael J. Wysocki
2007-12-16 18:59 ` Johannes Berg [this message]
2007-12-16 19:34 ` Johannes Berg
2007-12-16 20:56 ` Rafael J. Wysocki
2007-12-16 20:49 ` Johannes Berg
2007-12-16 21:03 ` Johannes Berg
2007-12-16 20:03 ` Benjamin Herrenschmidt
2007-12-16 20:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197831551.6769.13.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=jamey@crl.dec.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox