From: Johannes Berg <johannes@sipsolutions.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm <linux-pm@lists.linux-foundation.org>
Subject: [PATCH] PM: invoke suspend notifications after console switch
Date: Mon, 17 Dec 2007 02:09:58 +0100 [thread overview]
Message-ID: <1197853799.4885.7.camel@johannes.berg> (raw)
A subsequent patch will enable apm-emulation notification for suspends
triggered in any way by using the suspend notifications. This causes
the system to lock up between X being needed to switch away from the
VT and X already waiting for resume in the apm ioctl.
This patch moves the console switch (if enabled) before the suspend
notification (and after the resume notification) to avoid this issue.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
kernel/power/main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- everything.orig/kernel/power/main.c 2007-12-17 01:52:29.617085178 +0100
+++ everything/kernel/power/main.c 2007-12-17 01:53:23.547064887 +0100
@@ -73,12 +73,12 @@ static int suspend_prepare(void)
if (!suspend_ops || !suspend_ops->enter)
return -EPERM;
+ pm_prepare_console();
+
error = pm_notifier_call_chain(PM_SUSPEND_PREPARE);
if (error)
goto Finish;
- pm_prepare_console();
-
if (suspend_freeze_processes()) {
error = -EAGAIN;
goto Thaw;
@@ -98,9 +98,9 @@ static int suspend_prepare(void)
Thaw:
suspend_thaw_processes();
- pm_restore_console();
Finish:
pm_notifier_call_chain(PM_POST_SUSPEND);
+ pm_restore_console();
return error;
}
@@ -192,8 +192,8 @@ int suspend_devices_and_enter(suspend_st
static void suspend_finish(void)
{
suspend_thaw_processes();
- pm_restore_console();
pm_notifier_call_chain(PM_POST_SUSPEND);
+ pm_restore_console();
}
next reply other threads:[~2007-12-17 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 1:09 Johannes Berg [this message]
2008-01-10 13:14 ` [PATCH] PM: invoke suspend notifications after console switch Johannes Berg
2008-01-10 17:00 ` Rafael J. Wysocki
2008-01-11 18:20 ` Pavel Machek
2008-01-23 15:07 ` Rafael J. Wysocki
2008-01-23 18:03 ` Rafael J. Wysocki
2008-01-25 7:43 ` Pavel Machek
2008-01-24 0:46 ` Benjamin Herrenschmidt
2008-01-24 18:32 ` Johannes Berg
2008-01-24 8:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197853799.4885.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox