From: Rose Wu <ya-jou.wu@mediatek.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, <linux-pm@vger.kernel.org>
Cc: <rafael.j.wysocki@intel.com>, <regressions@lists.linux.dev>,
<linux-kernel@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
artis.chiu <artis.chiu@mediatek.com>,
Johnny-cc.Kao <Johnny-cc.Kao@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v1] PM: sleep: core: Fix runtime PM enabling in device_resume_early()
Date: Tue, 18 Nov 2025 16:31:08 +0800 [thread overview]
Message-ID: <119e2410ca32a0d55fa6febf93c7a3164b391db0.camel@mediatek.com> (raw)
In-Reply-To: <5940388.DvuYhMxLoT@rafael.j.wysocki>
Hi,
On Mon, 2025-11-17 at 19:57 +0100, Rafael J. Wysocki wrote:
>
> Make two changes to address this problem.
>
> First, reorder device_suspend_late() to only disable runtime PM for a
> device if the power.is_late_suspended flag is going to be set for it.
> In all of the other cases, disabling runtime PM for the device is not
> in fact necessary.
>
> Second, make device_resume_early() only enable runtime PM for the
> devices with the power.is_late_suspended flag set.
>
My concern is with the error path in device_suspend_late().
If a device fails its dpm_run_callback(), it appears that its
power.is_late_suspended flag is not set, potentially leaving its runtime
PM disabled during the resume sequence.
Regards,
Rose
next prev parent reply other threads:[~2025-11-18 8:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:31 [REGRESSION] PM / sleep: Unbalanced suspend/resume on late abort causes data abort Rose Wu
2025-11-17 16:59 ` Rafael J. Wysocki
2025-11-17 18:57 ` [PATCH v1] PM: sleep: core: Fix runtime PM enabling in device_resume_early() Rafael J. Wysocki
2025-11-18 8:31 ` Rose Wu [this message]
2025-11-18 11:48 ` [PATCH v2] " Rafael J. Wysocki
2025-11-18 12:17 ` Ulf Hansson
2025-11-18 12:26 ` Rafael J. Wysocki
2025-11-18 12:45 ` [PATCH v3] " Rafael J. Wysocki
2025-11-18 12:57 ` Ulf Hansson
2025-11-18 13:01 ` Rafael J. Wysocki
2025-11-18 14:16 ` [PATCH v4] " Rafael J. Wysocki
2025-11-18 14:44 ` Ulf Hansson
2025-11-18 12:49 ` [PATCH v2] " Ulf Hansson
2025-11-18 12:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119e2410ca32a0d55fa6febf93c7a3164b391db0.camel@mediatek.com \
--to=ya-jou.wu@mediatek.com \
--cc=Johnny-cc.Kao@mediatek.com \
--cc=artis.chiu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=ulf.hansson@linaro.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox