public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@crca.org.au>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@lists.linux-foundation.org, Yauhen Kharuzhy <jekhor@gmail.com>
Subject: Re: uevent before resume completion
Date: Mon, 06 Oct 2008 09:06:31 +1100	[thread overview]
Message-ID: <1223244391.28392.4.camel@nigel-laptop> (raw)
In-Reply-To: <20081005094947.GA2351@ucw.cz>

Hi.

On Sun, 2008-10-05 at 11:49 +0200, Pavel Machek wrote:
> On Mon 2008-09-22 17:19:59, Yauhen Kharuzhy wrote:
> > Hi.
> > 
> > We have an ARM board which does wakeup on USB cable connection to
> > it. In our power supply driver "USB connect" interrupt handler calls
> > power_supply_changed() which cause generation of uevent (in
> > power_supply_changed_work() ). But usermodehelper_disabled
> > still equals to 1 because resume process is not finished yet and
> > userspace helper is not executed.
> > 
> > How to fix this behaviour without breaking other kernel parts? We
> > definitely need to invoke userspace helper on USB cable insertion. Yes,
> > we can generate event after some time with timer but I think that a more
> > elegant solution can be found.
> 
> If you do it such that your 'delayed uevent' code can be reused by
> other subsystems, it should not be too bad...

One option would be to use the pm_notifier call chain, but it sounds to
me like a better solution would be for someone to modify the
kernel/kmod.c to handle delaying tasks until post hibernate/suspend if
they're UMH_NO_WAIT (Yauhen, is your call blocking?)

Regards,

Nigel

      reply	other threads:[~2008-10-05 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 14:19 uevent before resume completion Yauhen Kharuzhy
2008-10-05  9:49 ` Pavel Machek
2008-10-05 22:06   ` Nigel Cunningham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223244391.28392.4.camel@nigel-laptop \
    --to=ncunningham@crca.org.au \
    --cc=jekhor@gmail.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox