public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@crca.org.au>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/4] Hibernate: Call platform_begin before	swsusp_shrink_memory
Date: Thu, 23 Oct 2008 09:37:52 +1100	[thread overview]
Message-ID: <1224715072.8156.4.camel@nigel-laptop> (raw)
In-Reply-To: <200810222250.36537.rjw@sisk.pl>

Hi.

On Wed, 2008-10-22 at 22:50 +0200, Rafael J. Wysocki wrote:
> From: Zhang Rui <rui.zhang@intel.com>
> 
> Hibernate: Call platform_begin before swsusp_shrink_memory
> 
> Call platform_begin() before swsusp_shrink_memory() so that we can
> always allocate enough memory to save the ACPI NVS region from
> platform_begin().
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  kernel/power/disk.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6/kernel/power/disk.c
> ===================================================================
> --- linux-2.6.orig/kernel/power/disk.c
> +++ linux-2.6/kernel/power/disk.c
> @@ -267,12 +267,12 @@ int hibernation_snapshot(int platform_mo
>  {
>  	int error, ftrace_save;
>  
> -	/* Free memory before shutting down devices. */
> -	error = swsusp_shrink_memory();
> +	error = platform_begin(platform_mode);
>  	if (error)
>  		return error;
>  
> -	error = platform_begin(platform_mode);
> +	/* Free memory before shutting down devices. */
> +	error = swsusp_shrink_memory();
>  	if (error)
>  		goto Close;
>  

Acked-by: Nigel Cunningham <nigel@tuxonice.net>

  parent reply	other threads:[~2008-10-22 22:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200810222249.20629.rjw@sisk.pl>
2008-10-22 20:50 ` [PATCH 1/4] Hibernate: Call platform_begin before swsusp_shrink_memory Rafael J. Wysocki
2008-10-22 20:52 ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Rafael J. Wysocki
2008-10-22 20:53 ` [PATCH 3/4] x86 hibernate: Mark ACPI NVS memory region at startup Rafael J. Wysocki
2008-10-22 20:54 ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Rafael J. Wysocki
     [not found] ` <200810222250.36537.rjw@sisk.pl>
2008-10-22 22:37   ` Nigel Cunningham [this message]
2008-10-26 12:00   ` [PATCH 1/4] Hibernate: Call platform_begin before swsusp_shrink_memory Pavel Machek
     [not found] ` <200810222254.48666.rjw@sisk.pl>
2008-10-22 22:51   ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Nigel Cunningham
     [not found]   ` <1224715892.8156.16.camel@nigel-laptop>
2008-10-22 23:10     ` Rafael J. Wysocki
     [not found]     ` <200810230110.04039.rjw@sisk.pl>
2008-10-22 23:19       ` [PATCH 4/4] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs (rev. 2) Rafael J. Wysocki
     [not found]       ` <200810230119.55519.rjw@sisk.pl>
2008-10-26 12:18         ` Pavel Machek
     [not found] ` <200810222252.11625.rjw@sisk.pl>
2008-10-22 22:48   ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Nigel Cunningham
     [not found]   ` <1224715703.8156.11.camel@nigel-laptop>
2008-10-22 23:08     ` Rafael J. Wysocki
     [not found]     ` <200810230108.45101.rjw@sisk.pl>
2008-10-23  1:37       ` Nigel Cunningham
     [not found]       ` <1224725825.15620.1.camel@nigel-laptop>
2008-10-23  5:47         ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory (rev. 2) Rafael J. Wysocki
     [not found]         ` <200810230747.36119.rjw@sisk.pl>
2008-10-23  8:03           ` Nigel Cunningham
2008-10-26 12:08   ` [PATCH 2/4] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Pavel Machek
     [not found]   ` <20081026120838.GB1607@ucw.cz>
2008-10-26 12:23     ` Rafael J. Wysocki
     [not found]     ` <200810261323.21293.rjw@sisk.pl>
2008-11-18 16:14       ` Pavel Machek
     [not found] ` <200810222253.16264.rjw@sisk.pl>
2008-10-26 12:14   ` [PATCH 3/4] x86 hibernate: Mark ACPI NVS memory region at startup Pavel Machek
     [not found]   ` <20081026121404.GC1607@ucw.cz>
2008-10-26 12:29     ` Rafael J. Wysocki
     [not found]     ` <200810261329.16260.rjw@sisk.pl>
2008-10-29  9:21       ` Zhang Rui
     [not found]       ` <1225272091.2665.4.camel@rzhang-dt>
2008-10-29 11:18         ` Pavel Machek
     [not found]         ` <20081029111837.GA20466@atrey.karlin.mff.cuni.cz>
2008-10-30 23:59           ` Rafael J. Wysocki
     [not found] <200810262048.23468.rjw@sisk.pl>
2008-10-26 19:50 ` [PATCH 1/4] Hibernate: Call platform_begin before swsusp_shrink_memory Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224715072.8156.4.camel@nigel-laptop \
    --to=ncunningham@crca.org.au \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox