Re: [PATCH] hibernation should work ok with memory hotplug

Pavel Machek
2008-11-06T12:28:55Z

On Mon 2008-11-03 12:51:08, Andrew Morton wrote:
> On Wed, 29 Oct 2008 13:25:00 +0100
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > On Wednesday, 29 of October 2008, Pavel Machek wrote:
> > >
> > > hibernation + memory hotplug was disabled in kconfig because we could
> > > not handle hibernation + sparse mem at some point. It seems to work
> > > now, so I guess we can enable it.
> >
> > OK, if "it seems to work now" means that it has been tested and confirmed to
> > work, no objection from me.
>
> yes, that was not a terribly confidence-inspiring commit message.
>
> 3947be1969a9ce455ec30f60ef51efb10e4323d1 said "For now, disable memory
> hotplug when swsusp is enabled. There's a lot of churn there right
> now. We'll fix it up properly once it calms down." which is also
> rather rubbery.

I was not terribly confident. Sorry about that.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html