Re: [linux-pm] [PATCH] hibernation should work ok with memory hotplug

Nigel Cunningham
2008-11-04T07:30:37Z

Hi.

On Mon, 2008-11-03 at 23:09 -0800, Dave Hansen wrote:
> > So pfn 10 in the first node refers to the same memory as pfn 10 in the
> > second node?
>
> Sure. But, remember that the pfns (and the entire physical address
> space) is consistent across the entire system. It's not like both nodes
> have an address and the kernel only "gives" it to one of them.
>
> There's real confusion about zone->zone_start/end_pfn, I think. *All*
> that they mean is this:
>
> - zone_start_pfn is the lowest physical address present in the zone.
> - zone_end_pfn is the highest physical address present in the zone
>
> That's *it*. Those numbers imply *nothing* about the pages between
> them, except that there might be 0 or more pages in there belonging to
> the same zone.
>
> "All pages in this zone lie between these two physical addresses." is
> all they say.

Okay. Thanks (and to Rafael).

One other question, if I may. Would you please explain (or point me to
an explanation) of PHYS_PFN_OFFSET/ARCH_PFN_OFFSET? I've been dealing
occasionally with people wanting to have hibernation on arm, and I don't
really get the concept or the implementation (particularly when it comes
to trying to do the sort of iterating over zones and pfns that was being
discussed in previous messages in this thread.

Regards,

Nigel