From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Huang Rui <ray.huang@amd.com>, Meng Li <li.meng@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-acpi@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org,
Nathan Fontenot <nathan.fontenot@amd.com>,
Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Shimmer Huang <shimmer.huang@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH V7 0/7] amd-pstate preferred core
Date: Wed, 20 Sep 2023 21:34:17 +0200 [thread overview]
Message-ID: <12290212.O9o76ZdvQC@natalenko.name> (raw)
In-Reply-To: <ce377dda-e1ce-4553-b9b8-125620b8b2d7@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
Hello.
On středa 20. září 2023 18:56:09 CEST Mario Limonciello wrote:
> > When applied on top of v6.5.3 this breaks turbo on my 5950X after suspend/resume cycle. Please see the scenario description below.
> >
> > If I boot v6.5.3 + this patchset, then `turbostat` reports ~4.9 GHz on core 0 where `taskset -c 0 dd if=/dev/zero of=/dev/null` is being run.
> >
> > After I suspend the machine and then resume it, and run `dd` again, `turbostat` reports the core to be capped to a stock frequency of ~3.4 GHz. Rebooting the machine fixes this, and the CPU can boost again.
> >
> > If this patchset is reverted, then the CPU can turbo after suspend/resume cycle just fine.
> >
> > I'm using `amd_pstate=guided`.
> >
> > Is this behaviour expected?
>
> To help confirm where the issue is, can I ask you to do three
> experiments with the patch series applied:
>
> 1) 'amd_pstate=active' on your kernel command line.
The issue is reproducible. If I toggle the governor in cpupower to `powersave` and back to `performance`, boost is restored.
> 2) 'amd_pstate=active amd_prefcore=disable' on your kernel command line.
The issue is not reproducible.
> 3) 'amd_pstate=guided amd_prefcore=disable' on your kernel command line.
The issue is not reproducible.
I should also mention that in my initial configuration I use `amd_pstate=guided` and `schedutil`. If I switch to `performance` after suspend-resume cycle, the boost is restored. However, if I switch back to `schedutil`, the freq is capped.
Does this info help?
> Looking through the code, I anticipate from your report that it
> reproduces on "1" but not "2" and "3".
>
> Meng,
>
> Can you try to repro?
>
> I think that it's probably a call to amd_pstate_init_prefcore() missing
> from amd_pstate_cpu_resume() and also amd_pstate_epp_resume().
--
Oleksandr Natalenko (post-factum)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-20 19:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:14 [PATCH V7 0/7] amd-pstate preferred core Meng Li
2023-09-18 8:14 ` [PATCH V7 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion Meng Li
2023-09-18 8:14 ` [PATCH V7 2/7] acpi: cppc: Add get the highest performance cppc control Meng Li
2023-09-18 8:14 ` [PATCH V7 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting Meng Li
2023-09-20 2:43 ` Huang Rui
2023-09-18 8:14 ` [PATCH V7 4/7] cpufreq: Add a notification message that the highest perf has changed Meng Li
2023-09-18 8:14 ` [PATCH V7 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically Meng Li
2023-09-18 8:14 ` [PATCH V7 6/7] Documentation: amd-pstate: introduce amd-pstate preferred core Meng Li
2023-09-18 8:14 ` [PATCH V7 7/7] Documentation: introduce amd-pstate preferrd core mode kernel command line options Meng Li
2023-09-18 17:40 ` [PATCH V7 0/7] amd-pstate preferred core Mario Limonciello
2023-09-19 0:50 ` Meng, Li (Jassmine)
2023-09-18 17:44 ` Shuah Khan
2023-09-18 18:23 ` Shuah
2023-09-19 19:01 ` Oleksandr Natalenko
2023-09-20 16:56 ` Mario Limonciello
2023-09-20 19:34 ` Oleksandr Natalenko [this message]
2023-09-20 20:11 ` Mario Limonciello
2023-09-21 5:51 ` Meng, Li (Jassmine)
2023-09-20 2:50 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12290212.O9o76ZdvQC@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=shimmer.huang@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).