From: "Arve Hjønnevåg" <arve@android.com>
To: linux-pm@lists.linux-foundation.org
Cc: swetland@google.com
Subject: [PATCH 07/11] PM: wakelock: Abort task freezing if a wake lock is held.
Date: Tue, 13 Jan 2009 17:27:52 -0800 [thread overview]
Message-ID: <1231896476-22445-8-git-send-email-arve@android.com> (raw)
In-Reply-To: <1231896476-22445-7-git-send-email-arve@android.com>
Avoids a problem where the device sometimes hangs for 20 seconds
before the screen is turned on.
Signed-off-by: Arve Hjønnevåg <arve@android.com>
---
kernel/power/process.c | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/kernel/power/process.c b/kernel/power/process.c
index ca63401..8388d01 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -13,6 +13,7 @@
#include <linux/module.h>
#include <linux/syscalls.h>
#include <linux/freezer.h>
+#include <linux/wakelock.h>
/*
* Timeout for stopping processes
@@ -36,6 +37,7 @@ static int try_to_freeze_tasks(bool sig_only)
struct timeval start, end;
u64 elapsed_csecs64;
unsigned int elapsed_csecs;
+ unsigned int wakeup = 0;
do_gettimeofday(&start);
@@ -62,6 +64,10 @@ static int try_to_freeze_tasks(bool sig_only)
} while_each_thread(g, p);
read_unlock(&tasklist_lock);
yield(); /* Yield is okay here */
+ if (todo && has_wake_lock(WAKE_LOCK_SUSPEND)) {
+ wakeup = 1;
+ break;
+ }
if (time_after(jiffies, end_time))
break;
} while (todo);
@@ -77,11 +83,17 @@ static int try_to_freeze_tasks(bool sig_only)
* and caller must call thaw_processes() if something fails),
* but it cleans up leftover PF_FREEZE requests.
*/
- printk("\n");
- printk(KERN_ERR "Freezing of tasks failed after %d.%02d seconds "
- "(%d tasks refusing to freeze):\n",
- elapsed_csecs / 100, elapsed_csecs % 100, todo);
- show_state();
+ if (wakeup) {
+ printk("\n");
+ printk(KERN_ERR "Freezing of %s aborted\n",
+ sig_only ? "user space " : "tasks ");
+ } else {
+ printk("\n");
+ printk(KERN_ERR "Freezing of tasks failed after %d.%02d seconds "
+ "(%d tasks refusing to freeze):\n",
+ elapsed_csecs / 100, elapsed_csecs % 100, todo);
+ show_state();
+ }
read_lock(&tasklist_lock);
do_each_thread(g, p) {
task_lock(p);
--
1.6.1
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
next prev parent reply other threads:[~2009-01-14 1:27 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 1:27 [RFC][PATCH 00/11] Android PM extensions Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 01/11] PM: Add wake lock api Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 02/11] PM: Add early suspend api Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 03/11] PM: Implement wakelock api Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 04/11] PM: Implement early suspend api Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 05/11] PM: Enable early suspend through /sys/power/state Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 06/11] PM: Add user-space wake lock api Arve Hjønnevåg
2009-01-14 1:27 ` Arve Hjønnevåg [this message]
2009-01-14 1:27 ` [PATCH 08/11] PM: earlysuspend: Add console switch when user requested sleep state changes Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 09/11] PM: earlysuspend: Removing dependence on console Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 10/11] Input: Hold wake lock while event queue is not empty Arve Hjønnevåg
2009-01-14 1:27 ` [PATCH 11/11] ledtrig-sleep: Add led trigger for sleep debugging Arve Hjønnevåg
2009-01-30 12:43 ` [PATCH 06/11] PM: Add user-space wake lock api Uli Luckas
2009-01-31 0:17 ` Arve Hjønnevåg
2009-01-31 7:24 ` Brian Swetland
2009-01-28 19:34 ` [PATCH 05/11] PM: Enable early suspend through /sys/power/state Pavel Machek
2009-01-31 3:13 ` Arve Hjønnevåg
2009-01-31 15:49 ` Alan Stern
2009-02-02 11:44 ` Pavel Machek
2009-02-02 11:45 ` Pavel Machek
2009-02-02 22:36 ` Arve Hjønnevåg
2009-01-14 9:48 ` [PATCH 04/11] PM: Implement early suspend api Nigel Cunningham
2009-01-14 23:57 ` Arve Hjønnevåg
2009-01-14 9:30 ` [PATCH 03/11] PM: Implement wakelock api Nigel Cunningham
2009-01-14 23:28 ` Arve Hjønnevåg
2009-01-14 9:17 ` [PATCH 02/11] PM: Add early suspend api Nigel Cunningham
2009-01-14 23:18 ` Arve Hjønnevåg
2009-01-14 9:09 ` [PATCH 01/11] PM: Add wake lock api Nigel Cunningham
2009-01-14 23:07 ` Arve Hjønnevåg
2009-01-14 9:01 ` [RFC][PATCH 00/11] Android PM extensions Nigel Cunningham
2009-01-15 0:10 ` Arve Hjønnevåg
2009-01-15 4:42 ` Arve Hjønnevåg
2009-01-15 15:08 ` Alan Stern
2009-01-15 20:34 ` Arve Hjønnevåg
2009-01-29 13:04 ` Pavel Machek
2009-01-30 1:16 ` Arve Hjønnevåg
2009-01-30 3:27 ` Alan Stern
2009-01-30 4:40 ` Arve Hjønnevåg
2009-01-30 6:04 ` Arve Hjønnevåg
2009-02-02 11:49 ` Pavel Machek
2009-01-30 9:11 ` Pavel Machek
2009-01-30 12:34 ` Uli Luckas
2009-02-02 11:46 ` Pavel Machek
2009-01-30 15:13 ` Alan Stern
2009-01-31 0:02 ` Arve Hjønnevåg
2009-01-31 16:19 ` Alan Stern
2009-01-31 23:28 ` Arve Hjønnevåg
2009-02-02 10:42 ` Uli Luckas
2009-02-02 15:05 ` Alan Stern
2009-02-02 16:15 ` Uli Luckas
2009-02-02 16:35 ` Alan Stern
2009-02-03 20:15 ` Pavel Machek
2009-01-31 7:47 ` Brian Swetland
2009-01-31 15:41 ` Alan Stern
2009-01-31 18:39 ` Rafael J. Wysocki
2009-01-31 18:54 ` Igor Stoppa
2009-02-01 1:04 ` Arve Hjønnevåg
2009-02-02 11:55 ` Pavel Machek
2009-01-31 22:41 ` Arve Hjønnevåg
2009-01-31 23:20 ` Rafael J. Wysocki
2009-01-31 23:32 ` Arve Hjønnevåg
2009-02-01 0:18 ` Rafael J. Wysocki
2009-02-01 1:17 ` Arve Hjønnevåg
2009-02-01 1:32 ` Rafael J. Wysocki
2009-02-01 2:14 ` Arve Hjønnevåg
2009-02-01 12:30 ` Rafael J. Wysocki
2009-02-01 14:03 ` Woodruff, Richard
2009-02-01 17:43 ` Alan Stern
2009-02-01 19:27 ` Woodruff, Richard
2009-02-02 11:00 ` Uli Luckas
2009-02-02 15:09 ` Alan Stern
2009-02-02 16:24 ` Uli Luckas
2009-02-02 21:47 ` Nigel Cunningham
2009-02-02 23:21 ` Arve Hjønnevåg
2009-02-02 23:51 ` Nigel Cunningham
2009-02-03 0:08 ` Arve Hjønnevåg
2009-02-04 13:25 ` Pavel Machek
2009-02-02 23:10 ` Arve Hjønnevåg
2009-02-03 3:27 ` Alan Stern
2009-02-03 4:18 ` Arve Hjønnevåg
2009-02-03 20:30 ` Alan Stern
2009-02-04 13:29 ` Pavel Machek
2009-02-02 11:56 ` Pavel Machek
2009-02-02 12:38 ` Uli Luckas
2009-01-30 9:08 ` Pavel Machek
2009-01-30 9:25 ` Brian Swetland
2009-01-28 19:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231896476-22445-8-git-send-email-arve@android.com \
--to=arve@android.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox