From: Nigel Cunningham <ncunningham@crca.org.au>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
pavel@suse.cz, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] resume: wait for device probing to finish
Date: Thu, 15 Jan 2009 12:34:36 +1100 [thread overview]
Message-ID: <1231983276.7229.575.camel@nigel-laptop> (raw)
In-Reply-To: <200901150039.58972.rjw@sisk.pl>
Hi Rafael etc.
On Thu, 2009-01-15 at 00:39 +0100, Rafael J. Wysocki wrote:
[...]
> /**
> + * wait_for_device_probe
> + * Wait for device probing to be completed.
> + *
> + * Note: this function polls at 100 msec intervals.
> + */
> +int wait_for_device_probe(void)
> +{
> + /* wait for the known devices to complete their probing */
> + while (driver_probe_done() != 0)
> + msleep(100);
> + async_synchronize_full();
> + return 0;
> +}
> +
Am I missing something? I can't see why you're polling instead of using
probe_waitqueue.
Regards,
Nigel
next prev parent reply other threads:[~2009-01-15 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901142303.46166.rjw@sisk.pl>
2009-01-14 23:24 ` [PATCH] resume: wait for device probing to finish Andrew Morton
[not found] ` <20090114152444.64e1ddfb.akpm@linux-foundation.org>
2009-01-14 23:39 ` Rafael J. Wysocki
[not found] ` <200901150039.58972.rjw@sisk.pl>
2009-01-15 1:34 ` Nigel Cunningham [this message]
2009-01-15 9:23 ` Arjan van de Ven
2009-01-14 22:03 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231983276.7229.575.camel@nigel-laptop \
--to=ncunningham@crca.org.au \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox