Re: [PATCH 1/8] PM: Add suspend block api.

Pavel Machek
2009-05-02T20:51:37Z

Hi!

> > >> +config SUSPEND_BLOCK
> > >> + bool "Suspend block"
> > >> + depends on PM
> > >> + select RTC_LIB
> > >
> > > depends on RTC_LIB
> > >
> > > select doesn't really work and I don't think it ever will.
> >
> > Nothing depends on RTC_LIB, it is only selected.
>
> If nothing in your code needs anything depending on RTC_LIB, why select it?

He wants to say nothing in _kernel proper_ depends on RTC_LIB:

pavel@amd:/data/l/linux-good$ grep 'select RTC_LIB' `find . -name
"Kconfig"`
./arch/arm/Kconfig: select RTC_LIB
./arch/mips/Kconfig: select RTC_LIB
./drivers/rtc/Kconfig: select RTC_LIB
pavel@amd:/data/l/linux-good$ grep 'depends.*RTC_LIB' `find . -name
"Kconfig"`
pavel@amd:/data/l/linux-good$

RTC_LIB seems to be designed for select.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html