Re: [PATCH 3/9] PM: suspend_block: Abort task freezing if a suspend_blocker is active.

Nigel Cunningham
2009-05-08T22:27:06Z

Hi.

On Fri, 2009-05-08 at 16:40 +0200, Rafael J. Wysocki wrote:
> The timeout is actually a workaround for the problem that we don't
> really
> know if tasks are going to react to our freeze requests and how much time it is
> going to take. The current value of 20 s was chosen after a number of
> experiments showing that in some cases the freezing _was_ going to take so
> much time. Of course the question is whether it makes sense to give up earlier
> even if tasks would eventually freeze, but that's a different issue.

What were the circumstances in which freezing could take 20s?

> Now, I think the Arve's approach is reasonable. If we know in advace that
> we're not going to suspend, it's better to stop the freezing as soon as
> possible.

Agreed.

Regards,

Nigel