Re: [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu)

Sergey Senozhatsky
2010-06-16T09:34:42Z

[-- Attachment #1.1: Type: text/plain, Size: 455 bytes --]

On (06/15/10 23:05), Arjan van de Ven wrote:
> can we do this bit once, when the ts structure gets initialized?
> it's not like the cpu value will ever change...
>
>
Hello Arjan,

Sure we can. The question is where is the "proper place"?
for_each_possible_cpu in __init?

or something like

static DEFINE_PER_CPU(struct tick_sched, tick_cpu_sched);
int cpu = get_cpu();
&per_cpu(tick_cpu_sched, cpu)->cpu = cpu;
put_cpu();

Sergey

[-- Attachment #1.2: Type: application/pgp-signature, Size: 316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]