Re: [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu)

Arjan van de Ven
2010-06-16T06:05:41Z

On Tue, 15 Jun 2010 19:13:03 +0300
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

>
> I've changed struct tick_sched to match passed *ts and cpu. Also
> changed "&per_cpu(tick_cpu_sched, cpu)" call to "struct tick_sched
> *tick_get_tick_sched(int cpu)" which we already have.
>
> But I don't really like this part:
> struct tick_sched *tick_get_tick_sched(int cpu)
> {
> struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
> ts->cpu = cpu;
> ^^^^^^^^^^^^^
> return ts;
> }
>
> Please kindly review.

can we do this bit once, when the ts structure gets initialized?
it's not like the cpu value will ever change...

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org