Re: BUG: using smp_processor_id() in preemptible code: s2disk

Sergey Senozhatsky
2010-06-14T14:54:40Z

[-- Attachment #1.1: Type: text/plain, Size: 574 bytes --]

On (06/14/10 07:38), Arjan van de Ven wrote:
> > Hello,
> > Not sure if this simple solution is the correct one.
>
> it's not; the caller needs to pass in the cpu number I suspect for this
> to be really correct....
>
> I just returned from family emergency travel and will take a look today
>

I thought about patching

./drivers/cpuidle/governors/menu.c: if (nr_iowait_cpu())
./drivers/cpuidle/governors/menu.c: mult += 10 * nr_iowait_cpu();
./kernel/time/tick-sched.c: if (nr_iowait_cpu() > 0)

decided to patch nr_iowait_cpu instead.

Sergey

[-- Attachment #1.2: Type: application/pgp-signature, Size: 316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]