Re: Warnings from PM QoS plist usage

[James Bottomley <James.Bottomley@suse.de>]

On Thu, 2010-07-15 at 18:58 +0200, Rafael J. Wysocki wrote:
> On Thursday, July 15, 2010, Mark Brown wrote:
> > On Thu, Jul 15, 2010 at 08:12:58AM +0200, James Bottomley wrote:
> > > On Wed, 2010-07-14 at 10:35 +0100, Mark Brown wrote:
> > 
> > > > > I've not looked at the PM QoS code at all so I don't know what the
> > > > > appropriate place to fix this is - do we perhaps want to fix the debug
> > > > > code to cope with no locks?  Looking at the plist.h code it seems fairly
> > > > > clear that there's currently no expectation that users should use
> > > > > _PLIST_INIT_HEAD() directly.
> > 
> > > Sorry ... I just wasn't sure what it wanted without reading through the
> > > plist code more ... and also that debug item is hidden by
> > > CONFIG_DEBUG_RT_MUTEXES, which is why I couldn't enable it.
> > 
> > Ah, yes - I missed the existing spinlock.
> > 
> > > This should fix the warning.
> > 
> > It does indeed - thanks!
> > 
> > Tested-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> Thanks for testing.
> 
> James, I hope it's appropriate to add your sign-off to the patch?

Certainly

Signed-off-by: James Bottomley <James.Bottomley@suse.de>

Although I'd advise just folding it into the plist patch since it's not
gone upstream yet.

James