Re: [PATCH 1/2] PM: Compress hibernation image with LZO

[Bojan Smojver <bojan@rexursive.com>]

On Thu, 2010-08-19 at 19:49 +1000, Bojan Smojver wrote:
> I still have to see about Kconfig selects. Will
> get back to you on this 

For instance, we have this:
---------------------
config JFFS2_LZO
        bool "JFFS2 LZO compression support" if JFFS2_COMPRESSION_OPTIONS
        select LZO_COMPRESS
        select LZO_DECOMPRESS
        depends on JFFS2_FS
        default n
        help
          minilzo-based compression. Generally works better than Zlib.

          This feature was added in July, 2007. Say 'N' if you need
          compatibility with older bootloaders or kernels.
---------------------

And this:
---------------------
config ZRAM
        tristate "Compressed RAM block device support"
        depends on BLOCK
        select LZO_COMPRESS
        select LZO_DECOMPRESS
        default n
        help
          Creates virtual block devices called /dev/zramX (X = 0, 1, ...).
          Pages written to these disks are compressed and stored in memory
          itself. These disks allow very fast I/O and compression provides
          good amounts of memory savings.

          It has several use cases, for example: /tmp storage, use as swap
          disks and maybe many more.

          See zram.txt for more information.
          Project home: http://compcache.googlecode.com/
---------------------

And this:
---------------------
config CRYPTO_LZO
        tristate "LZO compression algorithm"
        select CRYPTO_ALGAPI
        select LZO_COMPRESS
        select LZO_DECOMPRESS
        help
          This is the LZO algorithm.
---------------------

And finally, we have this:
---------------------
#
# compression support is select'ed if needed
#
config ZLIB_INFLATE
        tristate

config ZLIB_DEFLATE
        tristate

config LZO_COMPRESS
        tristate

config LZO_DECOMPRESS
        tristate
---------------------

Which would suggest to me that selecting it is the right thing to do.

-- 
Bojan