From: Bojan Smojver <bojan@rexursive.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Karel Zak <kzak@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: Re: [PATCH] PM / Hibernate: Restore old swap signature to avoid user space breakage
Date: Mon, 06 Dec 2010 10:36:55 +1100 [thread overview]
Message-ID: <1291592215.2866.3.camel@shrek.rexursive.com> (raw)
In-Reply-To: <201012052324.30231.rjw@sisk.pl>
On Sun, 2010-12-05 at 23:24 +0100, Rafael J. Wysocki wrote:
> Commit 3624eb0 (PM / Hibernate: Modify signature used to mark swap)
> modified hibernate signature used to mark swap partitions containing
> hibernation images, but that turns out to have caused problems in
> libblkid on recent Ubuntu. Restore the old signature to avoid those
> problems.
Don't quite understand this change (sorry, probably just being obtuse).
The signature was changed to make sure older kernels don't handle
compressed images by accident, right? If so, this would seem like a bad
idea, because this is what can actually happen now.
Shouldn't user space learn how to handle both signatures instead?
--
Bojan
next parent reply other threads:[~2010-12-05 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201012052324.30231.rjw@sisk.pl>
2010-12-05 23:36 ` Bojan Smojver [this message]
2010-12-06 13:26 ` [PATCH] PM / Hibernate: Restore old swap signature to avoid user space breakage Karel Zak
[not found] ` <20101206132613.GB9421@nb.net.home>
2010-12-06 22:22 ` Rafael J. Wysocki
2010-12-11 19:58 ` Rafael J. Wysocki
[not found] ` <201012112058.09689.rjw@sisk.pl>
2010-12-11 20:30 ` Bojan Smojver
[not found] ` <1292099420.1630.3.camel@shrek.rexursive.com>
2010-12-11 20:36 ` Rafael J. Wysocki
[not found] ` <201012112136.23543.rjw@sisk.pl>
2010-12-11 20:47 ` Bojan Smojver
[not found] ` <1292100440.1630.11.camel@shrek.rexursive.com>
2010-12-11 20:49 ` R. J. Wysocki
2010-12-11 21:10 ` Bojan Smojver
2010-12-11 20:17 ` Rafael J. Wysocki
2010-12-05 22:24 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291592215.2866.3.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@treblig.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox