From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bojan Smojver Subject: Re: [PATCH] PM / Hibernate: Restore old swap signature to avoid user space breakage Date: Mon, 06 Dec 2010 10:36:55 +1100 Message-ID: <1291592215.2866.3.camel@shrek.rexursive.com> References: <201012052324.30231.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201012052324.30231.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: Linux-pm mailing list , Karel Zak , LKML , "Dr. David Alan Gilbert" List-Id: linux-pm@vger.kernel.org On Sun, 2010-12-05 at 23:24 +0100, Rafael J. Wysocki wrote: > Commit 3624eb0 (PM / Hibernate: Modify signature used to mark swap) > modified hibernate signature used to mark swap partitions containing > hibernation images, but that turns out to have caused problems in > libblkid on recent Ubuntu. Restore the old signature to avoid those > problems. Don't quite understand this change (sorry, probably just being obtuse). The signature was changed to make sure older kernels don't handle compressed images by accident, right? If so, this would seem like a bad idea, because this is what can actually happen now. Shouldn't user space learn how to handle both signatures instead? -- Bojan