From: borissh1983@gmail.com
To: Sebastian Reichel <sre@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: helpers: handle multi line in test_sysfs_prop_optional_list
Date: Fri, 26 Jun 2026 09:40:37 +0300 [thread overview]
Message-ID: <12928066.O9o76ZdvQC@beast> (raw)
In-Reply-To: 20260625125237.36605-1-borissh1983@gmail.com
On Thursday, 25 June 2026 15:52:37 Israel Daylight Time Boris Shtrasman wrote:
> Modify test_sysfs_prop_optional_list to allow multi line parameters, in
> order to comply with checkpatch output that limit line by 100 chars.
>
> Allow use cases like:
>
> test_sysfs_prop_optional_list \
> property_name "value1","value2","val3","very_long_option"\
> ,"extra_long_option" \
> ,"even_more_data"
>
> Signed-off-by: Boris Shtrasman <borissh1983@gmail.com>
> ---
> tools/testing/selftests/power_supply/helpers.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/power_supply/helpers.sh b/tools/testing/selftests/power_supply/helpers.sh
> index 1ec90d7c9108..8535cb7ed094 100644
> --- a/tools/testing/selftests/power_supply/helpers.sh
> +++ b/tools/testing/selftests/power_supply/helpers.sh
> @@ -108,7 +108,7 @@ test_sysfs_prop_optional_range() {
>
> test_sysfs_prop_optional_list() {
> PROP=$1
> - LIST=$2
> + shift
>
> TEST_NAME="$DEVNAME".sysfs."$PROP"
>
> @@ -118,9 +118,9 @@ test_sysfs_prop_optional_list() {
> valid=0
>
> OLDIFS=$IFS
> - IFS=","
> - for item in $LIST; do
> - if [ "$DATA" = "$item" ]; then
> + IFS=",IFS"
> + for item in $*; do
> + if [ "$item" ] && [ "$DATA" = "$item" ]; then
> valid=1
> break
> fi
>
A new version of this patch now at
https://lore.kernel.org/linux-pm/20260625160556.54830-1-borissh1983@gmail.com/
prev parent reply other threads:[~2026-06-26 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 12:52 [PATCH] selftests: helpers: handle multi line in test_sysfs_prop_optional_list Boris Shtrasman
2026-06-26 6:40 ` borissh1983 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12928066.O9o76ZdvQC@beast \
--to=borissh1983@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox