PROBLEM: Shutdown does not poweroff due to commit 2a2d31c8 "intel_idle: open broadcast clock event"

PROBLEM: Shutdown does not poweroff due to commit 2a2d31c8 "intel_idle: open broadcast clock event"

[Ari Savolainen]

Hi,

I have a Dell Precision WorkStation T3500. It stopped to power off
after shutdown. Bisection revealed commit 2a2d31c8 "intel_idle: open
broadcast clock event" to be the reason.  Below are all the dmesg
lines containing "intel_idle":

[    2.184560] intel_idle: MWAIT substates: 0x1120
[    2.184561] intel_idle: v0.4 model 0x1A
[    2.184562] intel_idle: lapic_timer_reliable_states 0x2
[    2.204056] ACPI: acpi_idle yielding to intel_idle

Please let me know what further information you need to fix the problem.

Regards,
Ari

Re: PROBLEM: Shutdown does not poweroff due to commit 2a2d31c8 "intel_idle: open broadcast clock event"

[Shaohua Li]

On Sat, 2011-01-22 at 02:03 +0800, Ari Savolainen wrote:
> Hi,
> 
> I have a Dell Precision WorkStation T3500. It stopped to power off
> after shutdown. Bisection revealed commit 2a2d31c8 "intel_idle: open
> broadcast clock event" to be the reason.  Below are all the dmesg
> lines containing "intel_idle":
> 
> [    2.184560] intel_idle: MWAIT substates: 0x1120
> [    2.184561] intel_idle: v0.4 model 0x1A
> [    2.184562] intel_idle: lapic_timer_reliable_states 0x2
> [    2.204056] ACPI: acpi_idle yielding to intel_idle
> 
> Please let me know what further information you need to fix the problem.
I can't reproduce it here, but can you please try below patch:

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 7acb32e..1fa091e 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -263,7 +263,7 @@ static void __setup_broadcast_timer(void *arg)
 	clockevents_notify(reason, &cpu);
 }
 
-static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
+static int setup_broadcast_cpuhp_notify(struct notifier_block *n,
 		unsigned long action, void *hcpu)
 {
 	int hotcpu = (unsigned long)hcpu;
@@ -273,15 +273,11 @@ static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
 		smp_call_function_single(hotcpu, __setup_broadcast_timer,
 			(void *)true, 1);
 		break;
-	case CPU_DOWN_PREPARE:
-		smp_call_function_single(hotcpu, __setup_broadcast_timer,
-			(void *)false, 1);
-		break;
 	}
 	return NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata setup_broadcast_notifier = {
+static struct notifier_block setup_broadcast_notifier = {
 	.notifier_call = setup_broadcast_cpuhp_notify,
 };
 

Re: PROBLEM: Shutdown does not poweroff due to commit 2a2d31c8 "intel_idle: open broadcast clock event"

[Ari Savolainen]

2011/1/24 Shaohua Li <shaohua.li@intel.com>:
> I can't reproduce it here, but can you please try below patch:
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 7acb32e..1fa091e 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -263,7 +263,7 @@ static void __setup_broadcast_timer(void *arg)
>        clockevents_notify(reason, &cpu);
>  }
>
> -static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
> +static int setup_broadcast_cpuhp_notify(struct notifier_block *n,
>                unsigned long action, void *hcpu)
>  {
>        int hotcpu = (unsigned long)hcpu;
> @@ -273,15 +273,11 @@ static int __cpuinit setup_broadcast_cpuhp_notify(struct notifier_block *n,
>                smp_call_function_single(hotcpu, __setup_broadcast_timer,
>                        (void *)true, 1);
>                break;
> -       case CPU_DOWN_PREPARE:
> -               smp_call_function_single(hotcpu, __setup_broadcast_timer,
> -                       (void *)false, 1);
> -               break;
>        }
>        return NOTIFY_OK;
>  }
>
> -static struct notifier_block __cpuinitdata setup_broadcast_notifier = {
> +static struct notifier_block setup_broadcast_notifier = {
>        .notifier_call = setup_broadcast_cpuhp_notify,
>  };
>

I tried your patch and it did fix the problem.

Ari