From: Mario Limonciello <mario.limonciello@amd.com>
To: Borislav Petkov <bp@alien8.de>, Sean Rhodes <sean@starlabs.systems>
Cc: x86@kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/pm: Save AMD CPUID leaf 7 across S3
Date: Mon, 10 Aug 2026 13:31:25 -0500 [thread overview]
Message-ID: <131d39d6-c2a9-4d80-99e9-526d347bf608@amd.com> (raw)
In-Reply-To: <20260806012923.GEanPjc0w24EdEquDk@fat_crate.local>
On 8/5/26 20:29, Borislav Petkov wrote:
> On Tue, Aug 04, 2026 at 08:22:36PM +0100, Sean Rhodes wrote:
>> If you're saying that because there might be a firmware solution, I am
>> all ears, but this issue is present with AMI CRB and coreboot+FSP -
>> hit a wall trying to fix it there.
>
Does this only happen in coreboot + FSP? Or it also happens in latest UEFI?
Does it only happen in S3 or also S0i3?
How about S4?
> I'm making sure you're using the latest one which might potentially have
> a fix...
>
>> Why not?
>
> Because we're not fixing three things with one patch and without a proper
> justification for the other two.
>
I would expect the restore of this register to be the platform
firmware's responsibility.
I don't know right now if this a BIOS bug, an suspend/resume bug, or how
wide of an impact it is.
Your fix might make sense for "this single platform", but we don't have
any evidence it's needed for any other one just yet.
We shouldn't make changes because there "might" be a problem. We need
affirmation from testing or an assertion from the BIOS team.
next prev parent reply other threads:[~2026-08-10 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:13 [PATCH] x86/pm: Save AMD CPUID leaf 7 across S3 Sean Rhodes
2026-08-04 18:49 ` Borislav Petkov
2026-08-04 19:22 ` Sean Rhodes
2026-08-06 1:29 ` Borislav Petkov
2026-08-10 18:31 ` Mario Limonciello [this message]
2026-08-10 19:42 ` Sean Rhodes
2026-08-10 20:07 ` Mario Limonciello
2026-08-10 21:33 ` Borislav Petkov
2026-08-11 18:25 ` Mario Limonciello
2026-08-11 18:40 ` Borislav Petkov
2026-08-11 18:45 ` Mario Limonciello
2026-08-12 7:42 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131d39d6-c2a9-4d80-99e9-526d347bf608@amd.com \
--to=mario.limonciello@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=sean@starlabs.systems \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox