From: Yanmin Zhang <yanmin_zhang@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Brown, Len" <len.brown@intel.com>,
ShuoX Liu <shuox.liu@intel.com>, Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
"H. Peter Anvin" <hpa@zytor.com>,
andi.kleen@intel.com, Thomas Gleixner <tglx@linutronix.de>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [linux-pm] [PATCH V3] cpuidle: Add a sysfs entry to disable specific C state for debug purpose.
Date: Tue, 13 Mar 2012 09:36:34 +0800 [thread overview]
Message-ID: <1331602594.1916.155.camel@ymzhang> (raw)
In-Reply-To: <20120312192936.GC24873@kroah.com>
On Mon, 2012-03-12 at 12:29 -0700, Greg KH wrote:
> On Mon, Mar 12, 2012 at 06:11:51PM +0000, Mark Brown wrote:
> > On Tue, Mar 06, 2012 at 06:39:35AM -0800, Greg KH wrote:
> >
> > > Do you know of any tools using these files? I have never heard of them,
> > > and I was told we should move these files years ago. So I don't think
> > > there should be any api issues.
> >
> > powertop uses them.
>
> Ok, then we can't move them all.
>
> We should then just move the ones that have multiple lines, as I'm
> pretty sure powertop doesn't use them, right?
All sys files under cpu/cpuXXX/cpuidle have single line. If we move
some files to debugfs and keep others under sysfs, users might be confused.
Should we go back to the 1st version which just adds the new entry to
sysfs?
In addition, should we move powertop to tools/?
Yanmin
next prev parent reply other threads:[~2012-03-13 1:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C6CB66606345BC4B80CBE69D22ABFBB1021C7F@SHSMSX101.ccr.corp.intel.com>
[not found] ` <1330647453.1916.7.camel@ymzhang>
[not found] ` <20120302142303.648285a7.akpm@linux-foundation.org>
[not found] ` <C6CB66606345BC4B80CBE69D22ABFBB10220E1@SHSMSX101.ccr.corp.intel.com>
2012-03-05 6:16 ` Subject: [PATCH] cpuidle: Add a sysfs entry to disable specific C state for debug purpose Deepthi Dharwar
2012-03-05 7:09 ` [PATCH V3] " ShuoX Liu
2012-03-05 10:18 ` Henrique de Moraes Holschuh
2012-03-05 12:20 ` Valentin, Eduardo
2012-03-06 1:54 ` [linux-pm] " Yanmin Zhang
2012-03-06 5:22 ` Greg KH
2012-03-06 5:51 ` Yanmin Zhang
2012-03-06 14:39 ` Greg KH
[not found] ` <1331082051.1916.124.camel@ymzhang>
[not found] ` <20120308180106.GD26516@kroah.com>
2012-03-12 9:19 ` [PATCH 1/3] cpuidle: Move cpuidle sysfs entry of each cpu to debugfs ShuoX Liu
2012-03-12 9:21 ` [PATCH 2/3] cpuidle: Add a debugfs entry to disable specific C state for debug purpose ShuoX Liu
2012-03-12 20:46 ` Matthew Garrett
2012-03-12 9:23 ` [PATCH 3/3] cpupower: Update the cpupower tool for new debugfs entries of cpuidle ShuoX Liu
2012-03-12 17:22 ` [PATCH 1/3] cpuidle: Move cpuidle sysfs entry of each cpu to debugfs Greg KH
2012-03-13 2:07 ` ShuoX Liu
2012-03-12 18:11 ` [PATCH V3] cpuidle: Add a sysfs entry to disable specific C state for debug purpose Mark Brown
2012-03-12 19:29 ` [linux-pm] " Greg KH
2012-03-13 1:36 ` Yanmin Zhang [this message]
2012-03-13 19:29 ` Greg KH
2012-03-14 0:55 ` Yanmin Zhang
2012-03-14 2:46 ` Greg KH
2012-03-14 3:24 ` [linux-pm] [PATCH v4] " ShuoX Liu
2012-03-16 0:23 ` Yanmin Zhang
2012-03-16 21:33 ` Andrew Morton
2012-03-18 13:38 ` Henrique de Moraes Holschuh
2012-03-16 22:23 ` Andrew Morton
2012-03-06 1:04 ` [PATCH V3] " Yanmin Zhang
2012-03-13 0:42 ` Henrique de Moraes Holschuh
2012-03-13 1:18 ` Yanmin Zhang
2012-03-13 20:49 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331602594.1916.155.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=shuox.liu@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).