From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yanmin Zhang Subject: Re: [linux-pm] [PATCH V3] cpuidle: Add a sysfs entry to disable specific C state for debug purpose. Date: Tue, 13 Mar 2012 09:36:34 +0800 Message-ID: <1331602594.1916.155.camel@ymzhang> References: <4F545A4E.8010801@linux.vnet.ibm.com> <4F5466C4.2090808@intel.com> <20120305101827.GA19408@khazad-dum.debian.net> <1330998885.1916.89.camel@ymzhang> <20120306052236.GA19416@kroah.com> <1331013078.1916.103.camel@ymzhang> <20120306143935.GA23346@kroah.com> <20120312181151.GE14020@sirena.org.uk> <20120312192936.GC24873@kroah.com> Reply-To: yanmin_zhang@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120312192936.GC24873@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: Mark Brown , "Brown, Len" , ShuoX Liu , Ingo Molnar , "linux-kernel@vger.kernel.org" , Henrique de Moraes Holschuh , "H. Peter Anvin" , andi.kleen@intel.com, Thomas Gleixner , "linux-pm@lists.linux-foundation.org" , Andrew Morton List-Id: linux-pm@vger.kernel.org On Mon, 2012-03-12 at 12:29 -0700, Greg KH wrote: > On Mon, Mar 12, 2012 at 06:11:51PM +0000, Mark Brown wrote: > > On Tue, Mar 06, 2012 at 06:39:35AM -0800, Greg KH wrote: > > > > > Do you know of any tools using these files? I have never heard of them, > > > and I was told we should move these files years ago. So I don't think > > > there should be any api issues. > > > > powertop uses them. > > Ok, then we can't move them all. > > We should then just move the ones that have multiple lines, as I'm > pretty sure powertop doesn't use them, right? All sys files under cpu/cpuXXX/cpuidle have single line. If we move some files to debugfs and keep others under sysfs, users might be confused. Should we go back to the 1st version which just adds the new entry to sysfs? In addition, should we move powertop to tools/? Yanmin