From: Eduardo Valentin <eduardo.valentin@ti.com>
To: rui.zhang@intel.com, durgadoss.r@intel.com
Cc: linux-pm@lists.linux-foundation.org
Subject: [PATCH 4/4] thermal sys: check for invalid trip setup when registering thermal device
Date: Tue, 12 Jun 2012 16:25:19 +0300 [thread overview]
Message-ID: <1339507519-14434-5-git-send-email-eduardo.valentin@ti.com> (raw)
In-Reply-To: <1339507519-14434-1-git-send-email-eduardo.valentin@ti.com>
This patch adds an extra check in the data structure while registering
a thermal device. The check is to avoid registering zones with a number
of trips greater than zero, but with no .get_trip_temp nor .get_trip_type
callbacks. Receiving such data structure may end in wrong data access.
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
drivers/thermal/thermal_sys.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 61d0003..50830f2 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -1129,6 +1129,9 @@ struct thermal_zone_device *thermal_zone_device_register(char *type,
if (!ops || !ops->get_temp)
return ERR_PTR(-EINVAL);
+ if (trips > 0 && !ops->get_trip_type)
+ return ERR_PTR(-EINVAL);
+
tz = kzalloc(sizeof(struct thermal_zone_device), GFP_KERNEL);
if (!tz)
return ERR_PTR(-ENOMEM);
--
1.7.7.1.488.ge8e1c
prev parent reply other threads:[~2012-06-12 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 13:25 [PATCH 0/4] thermal sys: couple of fixes and cleanups Eduardo Valentin
2012-06-12 13:25 ` [RFC] [PATCH 1/4] thermal: Use thermal zone device id in netlink messages Eduardo Valentin
2012-06-12 17:02 ` R, Durgadoss
2012-06-13 3:57 ` Valentin, Eduardo
2012-06-12 13:25 ` [PATCH 2/4] thermal: remove unnecessary include Eduardo Valentin
2012-06-12 13:25 ` [PATCH 3/4] thermal: cleanup: use dev_* helper functions Eduardo Valentin
2012-06-12 13:25 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339507519-14434-5-git-send-email-eduardo.valentin@ti.com \
--to=eduardo.valentin@ti.com \
--cc=durgadoss.r@intel.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).