From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Tyler Baker" <tyler.baker@linaro.org>,
박경민 <kyungmin.park@samsung.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback
Date: Thu, 21 Jan 2016 09:24:10 +0000 (GMT) [thread overview]
Message-ID: <1344895371.241491453368249580.JavaMail.weblogic@ep2mlwas01b> (raw)
>As per the documentation of the devfreq_dev_profile.target callback, set
>the freq argument to the new frequency before returning.
>
>This caused endless messages like this after recent changes in the core:
>
>devfreq 6000c800.actmon: Couldn't update frequency transition information.
>
>Signed-off-by: Tomeu Vizoso
>Reported-by: Tyler Baker
Ah.. this is critical and material for LTS queue.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>---
> drivers/devfreq/tegra-devfreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>index 848b93ee930f..fe9dce0245bf 100644
>--- a/drivers/devfreq/tegra-devfreq.c
>+++ b/drivers/devfreq/tegra-devfreq.c
>@@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> clk_set_min_rate(tegra->emc_clock, rate);
> clk_set_rate(tegra->emc_clock, 0);
>
>+ *freq = rate;
>+
> return 0;
> }
>
>--
>2.5.0
>
next reply other threads:[~2016-01-21 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 9:24 MyungJoo Ham [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-21 7:52 [PATCH] PM / devfreq: tegra: Set freq in rate callback Tomeu Vizoso
2016-01-21 10:54 ` Thierry Reding
2016-01-27 19:20 ` Tyler Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344895371.241491453368249580.JavaMail.weblogic@ep2mlwas01b \
--to=myungjoo.ham@samsung.com \
--cc=gnurou@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).