* Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback
@ 2016-01-21 9:24 MyungJoo Ham
0 siblings, 0 replies; 4+ messages in thread
From: MyungJoo Ham @ 2016-01-21 9:24 UTC (permalink / raw)
To: Tomeu Vizoso, linux-kernel@vger.kernel.org
Cc: Tyler Baker, 박경민, Stephen Warren,
Thierry Reding, Alexandre Courbot, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org
>As per the documentation of the devfreq_dev_profile.target callback, set
>the freq argument to the new frequency before returning.
>
>This caused endless messages like this after recent changes in the core:
>
>devfreq 6000c800.actmon: Couldn't update frequency transition information.
>
>Signed-off-by: Tomeu Vizoso
>Reported-by: Tyler Baker
Ah.. this is critical and material for LTS queue.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>---
> drivers/devfreq/tegra-devfreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>index 848b93ee930f..fe9dce0245bf 100644
>--- a/drivers/devfreq/tegra-devfreq.c
>+++ b/drivers/devfreq/tegra-devfreq.c
>@@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> clk_set_min_rate(tegra->emc_clock, rate);
> clk_set_rate(tegra->emc_clock, 0);
>
>+ *freq = rate;
>+
> return 0;
> }
>
>--
>2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PM / devfreq: tegra: Set freq in rate callback
@ 2016-01-21 7:52 Tomeu Vizoso
2016-01-21 10:54 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Tomeu Vizoso @ 2016-01-21 7:52 UTC (permalink / raw)
To: linux-kernel
Cc: Tyler Baker, Tomeu Vizoso, MyungJoo Ham, Kyungmin Park,
Stephen Warren, Thierry Reding, Alexandre Courbot, linux-pm,
linux-tegra
As per the documentation of the devfreq_dev_profile.target callback, set
the freq argument to the new frequency before returning.
This caused endless messages like this after recent changes in the core:
devfreq 6000c800.actmon: Couldn't update frequency transition information.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reported-by: Tyler Baker <tyler.baker@linaro.org>
---
drivers/devfreq/tegra-devfreq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index 848b93ee930f..fe9dce0245bf 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
clk_set_min_rate(tegra->emc_clock, rate);
clk_set_rate(tegra->emc_clock, 0);
+ *freq = rate;
+
return 0;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback
2016-01-21 7:52 Tomeu Vizoso
@ 2016-01-21 10:54 ` Thierry Reding
2016-01-27 19:20 ` Tyler Baker
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2016-01-21 10:54 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: linux-kernel, Tyler Baker, MyungJoo Ham, Kyungmin Park,
Stephen Warren, Alexandre Courbot, linux-pm, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
On Thu, Jan 21, 2016 at 08:52:26AM +0100, Tomeu Vizoso wrote:
> As per the documentation of the devfreq_dev_profile.target callback, set
> the freq argument to the new frequency before returning.
>
> This caused endless messages like this after recent changes in the core:
>
> devfreq 6000c800.actmon: Couldn't update frequency transition information.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reported-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> drivers/devfreq/tegra-devfreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> index 848b93ee930f..fe9dce0245bf 100644
> --- a/drivers/devfreq/tegra-devfreq.c
> +++ b/drivers/devfreq/tegra-devfreq.c
> @@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> clk_set_min_rate(tegra->emc_clock, rate);
> clk_set_rate(tegra->emc_clock, 0);
>
> + *freq = rate;
> +
> return 0;
> }
>
I had noticed it recently but hadn't got around to look into it, thanks
for fixing it.
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback
2016-01-21 10:54 ` Thierry Reding
@ 2016-01-27 19:20 ` Tyler Baker
0 siblings, 0 replies; 4+ messages in thread
From: Tyler Baker @ 2016-01-27 19:20 UTC (permalink / raw)
To: Thierry Reding
Cc: Tomeu Vizoso,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
MyungJoo Ham, Kyungmin Park, Stephen Warren, Alexandre Courbot,
linux-pm-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Hi Thierry,
On 21 January 2016 at 02:54, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Thu, Jan 21, 2016 at 08:52:26AM +0100, Tomeu Vizoso wrote:
>> As per the documentation of the devfreq_dev_profile.target callback, set
>> the freq argument to the new frequency before returning.
>>
>> This caused endless messages like this after recent changes in the core:
>>
>> devfreq 6000c800.actmon: Couldn't update frequency transition information.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
>> Reported-by: Tyler Baker <tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> drivers/devfreq/tegra-devfreq.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index 848b93ee930f..fe9dce0245bf 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
>> clk_set_min_rate(tegra->emc_clock, rate);
>> clk_set_rate(tegra->emc_clock, 0);
>>
>> + *freq = rate;
>> +
>> return 0;
>> }
>>
>
> I had noticed it recently but hadn't got around to look into it, thanks
> for fixing it.
>
> Tested-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
I don't see this patch in -next yet, so I'm guess it hasn't been
applied. Any chance you could pick it up? This issue is now
manifesting in mainline, and causing ton of noise in the boot reports.
Cheers,
Tyler
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-27 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 9:24 [PATCH] PM / devfreq: tegra: Set freq in rate callback MyungJoo Ham
-- strict thread matches above, loose matches on Subject: below --
2016-01-21 7:52 Tomeu Vizoso
2016-01-21 10:54 ` Thierry Reding
2016-01-27 19:20 ` Tyler Baker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).