Linux Power Management development
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
	Amit Kachhap <amit.kachhap@linaro.org>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	patches@linaro.org
Subject: [RFC PATCH 2/2] Thermal: Exynos : add missing dependency
Date: Thu, 15 Nov 2012 15:02:27 +0800	[thread overview]
Message-ID: <1352962947.2080.10.camel@rzhang1-mobl4> (raw)

there is still something unclear to me.

Amit, the next step should be remove this "depends on CPU_THERMAL"
line for EXYNOS driver, right?
If we do this, the exynos driver should work w/ or w/o CPU_THERMAL,
but should we have something like,
"hey, I like CPU_THERMAL, I work better with it set"?

"Select" does not work here
because it may block exynos driver when CPU_FREQ cleared.

any ideas on this?

thanks,
rui

 CPU_FREQ_TABLE depends on CPU_FREQ. Selecting
 CPU_FREQ_TABLE without checking for dependencies gives
 the following compilation warnings: warning:
 (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC &&
 UX500_SOC_DB8500 && CPU_THERMAL && EXYNOS_THERMAL)
 selects CPU_FREQ_TABLE which has unmet direct
 dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ)

Patch-based-on: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/thermal/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 937a23d..99b6587 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -96,7 +96,7 @@ config RCAR_THERMAL
 config EXYNOS_THERMAL
 	tristate "Temperature sensor on Samsung EXYNOS"
 	depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5)
-	select CPU_FREQ_TABLE
+	depends on CPU_THERMAL
 	help
 	  If you say yes here you get support for TMU (Thermal Managment
 	  Unit) on SAMSUNG EXYNOS series of SoC.
-- 
1.7.9.5




             reply	other threads:[~2012-11-15  7:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15  7:02 Zhang Rui [this message]
2012-11-15  8:41 ` [RFC PATCH 2/2] Thermal: Exynos : add missing dependency Amit Kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352962947.2080.10.camel@rzhang1-mobl4 \
    --to=rui.zhang@intel.com \
    --cc=amit.kachhap@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox