From: Zhang Rui <rui.zhang@intel.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-pm@vger.kernel.org, hongbo.zhang@linaro.com, patches@linaro.org
Subject: Re: [PATCH 1/1] thermal: cpu_cooling: Make 'notify_device' static
Date: Thu, 15 Nov 2012 15:43:59 +0800 [thread overview]
Message-ID: <1352965439.2080.13.camel@rzhang1-mobl4> (raw)
In-Reply-To: <1352962184-20970-1-git-send-email-sachin.kamat@linaro.org>
On Thu, 2012-11-15 at 12:19 +0530, Sachin Kamat wrote:
> Silences the following sparse warning:
>
> drivers/thermal/cpu_cooling.c:67:31: warning:
> symbol 'notify_device' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
applied to therml-next.
thanks,
rui
> ---
> drivers/thermal/cpu_cooling.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 392d57d..6f94c2c 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -64,7 +64,7 @@ static unsigned int cpufreq_dev_count;
>
> /* notify_table passes value to the CPUFREQ_ADJUST callback function. */
> #define NOTIFY_INVALID NULL
> -struct cpufreq_cooling_device *notify_device;
> +static struct cpufreq_cooling_device *notify_device;
>
> /**
> * get_idr - function to get a unique id.
prev parent reply other threads:[~2012-11-15 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 6:49 [PATCH 1/1] thermal: cpu_cooling: Make 'notify_device' static Sachin Kamat
2012-11-15 7:43 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352965439.2080.13.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=hongbo.zhang@linaro.com \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).