* [PATCH] [CPUFREQ] EXYNOS: Use static for functions used in only this file
@ 2012-11-20 5:59 Tushar Behera
2012-11-21 23:42 ` [PATCH] " Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Tushar Behera @ 2012-11-20 5:59 UTC (permalink / raw)
To: linux-pm, cpufreq; +Cc: rjw, patches
Fixes following sparse error.
drivers/cpufreq/exynos-cpufreq.c:34:5: warning: symbol
'exynos_verify_speed' was not declared. Should it be static?
drivers/cpufreq/exynos-cpufreq.c:40:14: warning: symbol
'exynos_getspeed' was not declared. Should it be static?
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/cpufreq/exynos-cpufreq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index af2d81e..eb057bf 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -31,13 +31,13 @@ static unsigned int locking_frequency;
static bool frequency_locked;
static DEFINE_MUTEX(cpufreq_lock);
-int exynos_verify_speed(struct cpufreq_policy *policy)
+static int exynos_verify_speed(struct cpufreq_policy *policy)
{
return cpufreq_frequency_table_verify(policy,
exynos_info->freq_table);
}
-unsigned int exynos_getspeed(unsigned int cpu)
+static unsigned int exynos_getspeed(unsigned int cpu)
{
return clk_get_rate(exynos_info->cpu_clk) / 1000;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EXYNOS: Use static for functions used in only this file
2012-11-20 5:59 [PATCH] [CPUFREQ] EXYNOS: Use static for functions used in only this file Tushar Behera
@ 2012-11-21 23:42 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-11-21 23:42 UTC (permalink / raw)
To: Tushar Behera; +Cc: linux-pm, cpufreq, patches
On Tuesday, November 20, 2012 11:29:14 AM Tushar Behera wrote:
> Fixes following sparse error.
> drivers/cpufreq/exynos-cpufreq.c:34:5: warning: symbol
> 'exynos_verify_speed' was not declared. Should it be static?
> drivers/cpufreq/exynos-cpufreq.c:40:14: warning: symbol
> 'exynos_getspeed' was not declared. Should it be static?
Applied to linux-pm.git/linux-next as v3.8 material.
Thanks,
Rafael
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index af2d81e..eb057bf 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -31,13 +31,13 @@ static unsigned int locking_frequency;
> static bool frequency_locked;
> static DEFINE_MUTEX(cpufreq_lock);
>
> -int exynos_verify_speed(struct cpufreq_policy *policy)
> +static int exynos_verify_speed(struct cpufreq_policy *policy)
> {
> return cpufreq_frequency_table_verify(policy,
> exynos_info->freq_table);
> }
>
> -unsigned int exynos_getspeed(unsigned int cpu)
> +static unsigned int exynos_getspeed(unsigned int cpu)
> {
> return clk_get_rate(exynos_info->cpu_clk) / 1000;
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-21 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 5:59 [PATCH] [CPUFREQ] EXYNOS: Use static for functions used in only this file Tushar Behera
2012-11-21 23:42 ` [PATCH] " Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).