Re: [PATCH 2/2] thermal: rcar: add .get_trip_type/temp and .notify support

[Zhang Rui <rui.zhang@intel.com>]

On Sun, 2012-11-25 at 17:40 -0800, Kuninori Morimoto wrote:
> Hi Zhang
> 
> Thank you for your reply
> 
> > > +static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
> > > +				      int trip, unsigned long *temp)
> > > +{
> > > +	struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> > > +
> > > +	/* see rcar_thermal_get_temp() */
> > > +	switch (trip) {
> > > +	case 0: /* -45 <= temp < +45 */
> > > +		*temp = -45 - 1;
> > > +		break;
> > 
> > does this mean you expect the thermal driver to take some action when
> > the temperature is higher than -45C?
> > 
> > > +	case 1: /* +45 <= temp < +90 */
> > > +		*temp = 45 - 1;
> > > +		break;
> > what do you expect to happen when the temperature is higher than 45C but
> > lower than 90C?
> > 
> > > +	case 2: /* +90 <= temp < +135 */
> > > +		*temp = 90 - 1;
> > > +		break;
> > > +	default:
> > > +		dev_err(priv->dev, "rcar driver trip error\n");
> > > +		return -EINVAL;
> > > +	}
> (snip)
> > >  static struct thermal_zone_device_ops rcar_thermal_zone_ops = {
> > > -	.get_temp = rcar_thermal_get_temp,
> > > +	.get_temp	= rcar_thermal_get_temp,
> > > +	.get_trip_type	= rcar_thermal_get_trip_type,
> > > +	.get_trip_temp	= rcar_thermal_get_trip_temp,
> > > +	.notify		= rcar_thermal_notify,
> > >  };
> > >  
> > how does the active trip point work if you do not bind any cooling
> > devices to it?
> > 
> > >  /*
> > > @@ -212,8 +286,9 @@ static int rcar_thermal_probe(struct platform_device *pdev)
> > >  		goto error_free_priv;
> > >  	}
> > >  
> > > -	zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
> > > -					    &rcar_thermal_zone_ops, 0, 0);
> > > +	zone = thermal_zone_device_register("rcar_thermal", 4, 0, priv,
> > > +					    &rcar_thermal_zone_ops, 0,
> > > +					    IDLE_INTERVAL);
> > 
> > there is no interrupt for any thermal changes on this platform,
> > including critical overheat, right?
> 
> Now, we need critical shutdown only at this point.
> Then, should I remove active/hot trip ?
> If yes, I can send v2 patch.
> 
yep, please remove active and hot trip points.

> BTW, does thermal frame work use 45C ? or 45*1000 mC ?
> Maybe A * 1000 mC is correct ?
> 

I'm not sure if I understand correctly.
The unit of trip point temperature is Milli-Celsius.

thanks,
rui