From: Zhang Rui <rui.zhang@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>, Magnus <magnus.damm@gmail.com>,
linux-pm@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 3/3] thermal: rcar: add .get_trip_type/temp and .notify support
Date: Mon, 03 Dec 2012 10:22:37 +0800 [thread overview]
Message-ID: <1354501357.1936.35.camel@rzhang1-mobl4> (raw)
In-Reply-To: <87ip8jri4f.wl%kuninori.morimoto.gx@renesas.com>
On Sun, 2012-12-02 at 18:20 -0800, Kuninori Morimoto wrote:
> Hi Zhang
>
> > > +static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
> > > + int trip, unsigned long *temp)
> > > +{
> > > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> > > +
> > > + /* see rcar_thermal_get_temp() */
> > > + switch (trip) {
> > > + case 0: /* +90 <= temp < +135 */
> > > + *temp = MCELSIUS(90 - 1);
> >
> > what does the comment above mean?
> > the system is supposed to run from 90C to 135C? but you're setting the
> > critical trip point to 89C.
>
> Oops, sorry my original patch used old kernel for test.
> Then it needed this -1.
> But now it was already solved by this patch.
>
> 29321357ac6db54eeb8574da1f6c3e0ce8cfbb60
> (thermal: fix off-by-1 error in trip point trigger condition)
>
> I can fix this, but which is best for you ?
> v2 patch ? or additional patch ?
>
please send V2.
thanks,
rui
next prev parent reply other threads:[~2012-12-03 2:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 6:49 [PATCH 0/2] thermal: rcar: add emergency power down Kuninori Morimoto
2012-11-22 6:50 ` [PATCH 1/2] thermal: rcar: add rcar_zone_to_priv() macro Kuninori Morimoto
2012-11-25 9:24 ` Zhang Rui
2012-11-22 6:50 ` [PATCH 2/2] thermal: rcar: add .get_trip_type/temp and .notify support Kuninori Morimoto
2012-11-22 7:05 ` Magnus Damm
2012-11-23 6:29 ` Zhang Rui
2012-11-26 1:40 ` Kuninori Morimoto
2012-11-26 1:52 ` Zhang Rui
2012-11-26 2:30 ` [PATCH 0/3 v2] thermal: rcar: add critical shutdown support Kuninori Morimoto
2012-11-26 2:32 ` [PATCH 1/3] thermal: rcar: fixup the unit of temperature Kuninori Morimoto, Kuninori Morimoto
2012-11-26 2:59 ` Zhang Rui
2012-11-26 2:32 ` [PATCH 2/3] thermal: rcar: add rcar_zone_to_priv() macro Kuninori Morimoto, Kuninori Morimoto
2012-11-26 2:59 ` Zhang Rui
2012-11-26 2:32 ` [PATCH 3/3] thermal: rcar: add .get_trip_type/temp and .notify support Kuninori Morimoto, Kuninori Morimoto
2012-12-03 0:15 ` Kuninori Morimoto
2012-12-03 1:09 ` Zhang Rui
2012-12-03 2:11 ` Kuninori Morimoto
2012-12-03 1:02 ` Zhang Rui
2012-12-03 2:20 ` Kuninori Morimoto
2012-12-03 2:22 ` Zhang Rui [this message]
2012-12-03 2:25 ` Zhang Rui
2012-12-03 2:39 ` Kuninori Morimoto
2012-12-03 2:48 ` [PATCH v2] " Kuninori Morimoto, Kuninori Morimoto
2013-01-04 7:23 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354501357.1936.35.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).