From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivaram Nair Subject: [PATCH 2/2] cpuidle: fix sysfs output for power_usage Date: Fri, 14 Dec 2012 15:17:37 +0200 Message-ID: <1355491060-970-2-git-send-email-sivaramn@nvidia.com> References: <1355491060-970-1-git-send-email-sivaramn@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from hqemgate03.nvidia.com ([216.228.121.140]:3007 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116Ab2LNNS1 (ORCPT ); Fri, 14 Dec 2012 08:18:27 -0500 In-Reply-To: <1355491060-970-1-git-send-email-sivaramn@nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: rafael.j.wysocki@intel.com, daniel.lezcano@linaro.org, shuox.liu@intel.com, akpm@linux-foundation.org, yanmin_zhang@intel.com Cc: linux-pm@vger.kernel.org, Sivaram Nair , linux-kernel@vger.kernel.org cpuidle_state->power_usage is signed; so change the corresponding sysfs ops to output signed value instead of unsigned. Signed-off-by: Sivaram Nair --- drivers/cpuidle/sysfs.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c index 3409429..2fc79cd 100644 --- a/drivers/cpuidle/sysfs.c +++ b/drivers/cpuidle/sysfs.c @@ -232,6 +232,13 @@ static struct cpuidle_state_attr attr_##_name = __ATTR(_name, 0644, show, store) static ssize_t show_state_##_name(struct cpuidle_state *state, \ struct cpuidle_state_usage *state_usage, char *buf) \ { \ + return sprintf(buf, "%d\n", state->_name);\ +} + +#define define_show_state_u_function(_name) \ +static ssize_t show_state_##_name(struct cpuidle_state *state, \ + struct cpuidle_state_usage *state_usage, char *buf) \ +{ \ return sprintf(buf, "%u\n", state->_name);\ } @@ -270,7 +277,7 @@ static ssize_t show_state_##_name(struct cpuidle_state *state, \ return sprintf(buf, "%s\n", state->_name);\ } -define_show_state_function(exit_latency) +define_show_state_u_function(exit_latency) define_show_state_function(power_usage) define_show_state_ull_function(usage) define_show_state_ull_function(time) -- 1.7.9.5