From: Joe Perches <joe@perches.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Zhang Rui <rui.zhang@intel.com>, Rob Landley <rob@landley.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH v4 3/3] PM: Introduce Intel PowerClamp Driver
Date: Thu, 03 Jan 2013 11:34:14 -0800 [thread overview]
Message-ID: <1357241654.5452.16.camel@joe-AO722> (raw)
In-Reply-To: <1357210875-5025-4-git-send-email-jacob.jun.pan@linux.intel.com>
On Thu, 2013-01-03 at 03:01 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.
just trivia:
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> +static int clamping;
bool and use true/false?
> +static int window_size_set(const char *arg, const struct kernel_param *kp)
[]
> + if (new_window_size >= 10 || new_window_size < 2) {
> + pr_err("Invalid window size %lu, between 2-10\n",
> + new_window_size);
This is a misleading message or a bad test,
It's from 2 to 9
This would more normally be tested/written as
val < low || val > high
next prev parent reply other threads:[~2013-01-03 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 11:01 [PATCH v4 0/3] PM: Intel PowerClamp driver Jacob Pan
2013-01-03 11:01 ` [PATCH v4 1/3] tick: export nohz tick idle symbols for module use Jacob Pan
2013-01-03 11:01 ` [PATCH v4 2/3] x86/nmi: export local_touch_nmi() symbol for modules Jacob Pan
2013-01-03 11:01 ` [PATCH v4 3/3] PM: Introduce Intel PowerClamp Driver Jacob Pan
2013-01-03 19:34 ` Joe Perches [this message]
2013-01-03 15:03 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357241654.5452.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rob@landley.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).