[PATCH 0/2] PM / OPP : export symbol consolidation

[PATCH 0/2] PM / OPP : export symbol consolidation

[Nishanth Menon]

Hi,
This is a consolidation of Rafael's request for usage of EXPORT_SYMBOL_GPL
and requirement for cpufreq helpers to be exported to be used by cpufreq
drivers which may be modules.

https://patchwork.kernel.org/patch/1847261/ is patch #2 in this series.

Mark Langsdorf (1):
  PM / OPP: Export more symbols for module usage

Nishanth Menon (1):
  PM / OPP: switch exported symbols to GPL variant

 drivers/base/power/opp.c |   19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

-- 
1.7.9.5

Regards,
Nishanth Menon

[PATCH 1/2] PM / OPP: switch exported symbols to GPL variant

[Nishanth Menon]

We are GPLV2 library, so be clear in the symbols exported as well.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 drivers/base/power/opp.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 50b2831..0dbe270 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -162,7 +162,7 @@ unsigned long opp_get_voltage(struct opp *opp)
 
 	return v;
 }
-EXPORT_SYMBOL(opp_get_voltage);
+EXPORT_SYMBOL_GPL(opp_get_voltage);
 
 /**
  * opp_get_freq() - Gets the frequency corresponding to an available opp
@@ -192,7 +192,7 @@ unsigned long opp_get_freq(struct opp *opp)
 
 	return f;
 }
-EXPORT_SYMBOL(opp_get_freq);
+EXPORT_SYMBOL_GPL(opp_get_freq);
 
 /**
  * opp_get_opp_count() - Get number of opps available in the opp list
@@ -225,7 +225,7 @@ int opp_get_opp_count(struct device *dev)
 
 	return count;
 }
-EXPORT_SYMBOL(opp_get_opp_count);
+EXPORT_SYMBOL_GPL(opp_get_opp_count);
 
 /**
  * opp_find_freq_exact() - search for an exact frequency
@@ -276,7 +276,7 @@ struct opp *opp_find_freq_exact(struct device *dev, unsigned long freq,
 
 	return opp;
 }
-EXPORT_SYMBOL(opp_find_freq_exact);
+EXPORT_SYMBOL_GPL(opp_find_freq_exact);
 
 /**
  * opp_find_freq_ceil() - Search for an rounded ceil freq
@@ -323,7 +323,7 @@ struct opp *opp_find_freq_ceil(struct device *dev, unsigned long *freq)
 
 	return opp;
 }
-EXPORT_SYMBOL(opp_find_freq_ceil);
+EXPORT_SYMBOL_GPL(opp_find_freq_ceil);
 
 /**
  * opp_find_freq_floor() - Search for a rounded floor freq
@@ -374,7 +374,7 @@ struct opp *opp_find_freq_floor(struct device *dev, unsigned long *freq)
 
 	return opp;
 }
-EXPORT_SYMBOL(opp_find_freq_floor);
+EXPORT_SYMBOL_GPL(opp_find_freq_floor);
 
 /**
  * opp_add()  - Add an OPP table from a table definitions
@@ -568,7 +568,7 @@ int opp_enable(struct device *dev, unsigned long freq)
 {
 	return opp_set_availability(dev, freq, true);
 }
-EXPORT_SYMBOL(opp_enable);
+EXPORT_SYMBOL_GPL(opp_enable);
 
 /**
  * opp_disable() - Disable a specific OPP
@@ -590,7 +590,7 @@ int opp_disable(struct device *dev, unsigned long freq)
 {
 	return opp_set_availability(dev, freq, false);
 }
-EXPORT_SYMBOL(opp_disable);
+EXPORT_SYMBOL_GPL(opp_disable);
 
 #ifdef CONFIG_CPU_FREQ
 /**
-- 
1.7.9.5

[PATCH 2/2] PM / OPP: Export more symbols for module usage

[Nishanth Menon]

From: Mark Langsdorf <mark.langsdorf@calxeda.com>

Export cpufreq helpers in OPP to make the cpufreq-core0 and highbank-cpufreq
drivers loadable as modules.

Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 drivers/base/power/opp.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 0dbe270..32ee0fc 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -661,6 +661,7 @@ int opp_init_cpufreq_table(struct device *dev,
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(opp_init_cpufreq_table);
 
 /**
  * opp_free_cpufreq_table() - free the cpufreq table
@@ -678,6 +679,7 @@ void opp_free_cpufreq_table(struct device *dev,
 	kfree(*table);
 	*table = NULL;
 }
+EXPORT_SYMBOL_GPL(opp_free_cpufreq_table);
 #endif		/* CONFIG_CPU_FREQ */
 
 /**
@@ -738,4 +740,5 @@ int of_init_opp_table(struct device *dev)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(of_init_opp_table);
 #endif
-- 
1.7.9.5

Re: [PATCH 0/2] PM / OPP : export symbol consolidation

[Shawn Guo]

On Mon, Jan 28, 2013 at 12:26:14PM -0600, Nishanth Menon wrote:
> Hi,
> This is a consolidation of Rafael's request for usage of EXPORT_SYMBOL_GPL
> and requirement for cpufreq helpers to be exported to be used by cpufreq
> drivers which may be modules.
> 
> https://patchwork.kernel.org/patch/1847261/ is patch #2 in this series.
> 
> Mark Langsdorf (1):
>   PM / OPP: Export more symbols for module usage
> 
> Nishanth Menon (1):
>   PM / OPP: switch exported symbols to GPL variant
> 
The series is needed by cpufreq-cpu0 and imx6q-cpufreq module build.
So, for both patches,

Acked-by: Shawn Guo <shawn.guo@linaro.org>