From: Huang Ying <ying.huang@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Huang Ying <ying.huang@intel.com>
Subject: [PATCH 3/4] PCI/PM: Set pci_dev->set_d3cold in pci_set_power_state
Date: Tue, 29 Jan 2013 12:34:17 +0800 [thread overview]
Message-ID: <1359434058-15918-4-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1359434058-15918-1-git-send-email-ying.huang@intel.com>
Because now pci_dev->set_d3cold is only used after
pci_set_power_state(, PCI_D3cold) and before pci_set_power_state(,
PCI_D0). And we will use pci_dev->set_d3cold for D3cold support
during system suspend too, but now pci_dev->set_d3cold is set only in
runtime power management code path now.
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/pci/pci-driver.c | 2 --
drivers/pci/pci.c | 12 +++++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -1036,8 +1036,6 @@ static int pci_pm_runtime_resume(struct
rc = pm->runtime_resume(dev);
- pci_dev->set_d3cold = false;
-
return rc;
}
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -775,6 +775,9 @@ int pci_set_power_state(struct pci_dev *
if (dev->current_state == state)
return 0;
+ if (state == PCI_D3cold)
+ dev->set_d3cold = true;
+
__pci_start_power_transition(dev, state);
/* This device is quirked not to be put into D3, so
@@ -798,6 +801,9 @@ int pci_set_power_state(struct pci_dev *
if (!error && dev->bus->self)
pcie_aspm_powersave_config_link(dev->bus->self);
+ if (error || state != PCI_D3cold)
+ dev->set_d3cold = false;
+
return error;
}
@@ -1833,16 +1839,12 @@ int pci_finish_runtime_suspend(struct pc
if (target_state == PCI_POWER_ERROR)
return -EIO;
- dev->set_d3cold = target_state == PCI_D3cold;
-
__pci_enable_wake(dev, target_state, true, pci_dev_run_wake(dev));
error = pci_set_power_state(dev, target_state);
- if (error) {
+ if (error)
__pci_enable_wake(dev, target_state, true, false);
- dev->set_d3cold = false;
- }
return error;
}
next prev parent reply other threads:[~2013-01-29 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 4:34 [PATCH 0/4] PCI/PM: D3cold support for system suspend Huang Ying
2013-01-29 4:34 ` [PATCH 1/4] PCI/ACPI: Add target state as parameter to pci_platform_pm_ops->run_wake Huang Ying
2013-01-29 4:34 ` [PATCH 2/4] PCI: Rename pci_dev->runtime_d3cold to pci_dev->set_d3cold Huang Ying
2013-01-29 4:34 ` Huang Ying [this message]
2013-01-29 4:34 ` [PATCH 4/4] PCI/PM: Enable D3cold support for system suspend Huang Ying
2013-04-04 18:26 ` [PATCH 0/4] PCI/PM: " Bjorn Helgaas
2013-04-04 20:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359434058-15918-4-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).