From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
swarren@wwwdotorg.org, linaro-dev@lists.linaro.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
mathieu.poirier@linaro.org, Joseph Lo <josephl@nvidia.com>,
linux-kernel@vger.kernel.org,
Fabio Baltieri <fabio.baltieri@linaro.org>
Subject: [PATCH v7 3/4] cpufreq: conservative: call dbs_check_cpu only when necessary
Date: Wed, 30 Jan 2013 14:00:02 +0100 [thread overview]
Message-ID: <1359550803-18577-4-git-send-email-fabio.baltieri@linaro.org> (raw)
In-Reply-To: <1359550803-18577-1-git-send-email-fabio.baltieri@linaro.org>
Modify conservative timer to not resample CPU utilization if recently
sampled from another SW coordinated core.
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
drivers/cpufreq/cpufreq_conservative.c | 47 +++++++++++++++++++++++++++++-----
1 file changed, 41 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
index b9d7f14..5d8e894 100644
--- a/drivers/cpufreq/cpufreq_conservative.c
+++ b/drivers/cpufreq/cpufreq_conservative.c
@@ -111,22 +111,57 @@ static void cs_check_cpu(int cpu, unsigned int load)
}
}
-static void cs_dbs_timer(struct work_struct *work)
+static void cs_timer_update(struct cs_cpu_dbs_info_s *dbs_info, bool sample,
+ struct delayed_work *dw)
{
- struct cs_cpu_dbs_info_s *dbs_info = container_of(work,
- struct cs_cpu_dbs_info_s, cdbs.work.work);
unsigned int cpu = dbs_info->cdbs.cpu;
int delay = delay_for_sampling_rate(cs_tuners.sampling_rate);
+ if (sample)
+ dbs_check_cpu(&cs_dbs_data, cpu);
+
+ schedule_delayed_work_on(smp_processor_id(), dw, delay);
+}
+
+static void cs_timer_coordinated(struct cs_cpu_dbs_info_s *dbs_info_local,
+ struct delayed_work *dw)
+{
+ struct cs_cpu_dbs_info_s *dbs_info;
+ ktime_t time_now;
+ s64 delta_us;
+ bool sample = true;
+
+ /* use leader CPU's dbs_info */
+ dbs_info = &per_cpu(cs_cpu_dbs_info, dbs_info_local->cdbs.cpu);
mutex_lock(&dbs_info->cdbs.timer_mutex);
- dbs_check_cpu(&cs_dbs_data, cpu);
+ time_now = ktime_get();
+ delta_us = ktime_us_delta(time_now, dbs_info->cdbs.time_stamp);
- schedule_delayed_work_on(smp_processor_id(), &dbs_info->cdbs.work,
- delay);
+ /* Do nothing if we recently have sampled */
+ if (delta_us < (s64)(cs_tuners.sampling_rate / 2))
+ sample = false;
+ else
+ dbs_info->cdbs.time_stamp = time_now;
+
+ cs_timer_update(dbs_info, sample, dw);
mutex_unlock(&dbs_info->cdbs.timer_mutex);
}
+static void cs_dbs_timer(struct work_struct *work)
+{
+ struct delayed_work *dw = to_delayed_work(work);
+ struct cs_cpu_dbs_info_s *dbs_info = container_of(work,
+ struct cs_cpu_dbs_info_s, cdbs.work.work);
+
+ if (dbs_sw_coordinated_cpus(&dbs_info->cdbs)) {
+ cs_timer_coordinated(dbs_info, dw);
+ } else {
+ mutex_lock(&dbs_info->cdbs.timer_mutex);
+ cs_timer_update(dbs_info, true, dw);
+ mutex_unlock(&dbs_info->cdbs.timer_mutex);
+ }
+}
static int dbs_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
void *data)
{
--
1.7.12.1
next prev parent reply other threads:[~2013-01-30 13:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:59 [PATCH v7 0/5] cpufreq: handle SW coordinated CPUs Fabio Baltieri
2013-01-30 13:00 ` [PATCH v7 1/4] " Fabio Baltieri
2013-01-30 15:02 ` Viresh Kumar
2013-01-30 16:23 ` Fabio Baltieri
2013-01-30 16:51 ` Viresh Kumar
2013-01-30 16:57 ` Fabio Baltieri
2013-01-30 21:44 ` Rafael J. Wysocki
2013-01-30 13:00 ` [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary Fabio Baltieri
2013-01-30 15:51 ` Viresh Kumar
2013-01-30 16:46 ` Fabio Baltieri
[not found] ` <20130130164614.GC30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:11 ` Viresh Kumar
2013-01-31 8:39 ` Fabio Baltieri
[not found] ` <20130131083825.GA30667-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-31 8:42 ` Viresh Kumar
2013-01-31 9:06 ` Fabio Baltieri
2013-01-31 9:11 ` Viresh Kumar
2013-01-30 13:00 ` Fabio Baltieri [this message]
2013-01-30 15:53 ` [PATCH v7 3/4] cpufreq: conservative: " Viresh Kumar
2013-01-30 16:53 ` Fabio Baltieri
[not found] ` <20130130165321.GD30559-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org>
2013-01-30 17:12 ` Viresh Kumar
[not found] ` <1359550803-18577-1-git-send-email-fabio.baltieri-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-30 13:00 ` [PATCH v7 4/4] cpufreq: ondemand: use all CPUs in update_sampling_rate Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359550803-18577-4-git-send-email-fabio.baltieri@linaro.org \
--to=fabio.baltieri@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=josephl@nvidia.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=rjw@sisk.pl \
--cc=swarren@wwwdotorg.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).