From: Zhang Rui <rui.zhang@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>, Magnus <magnus.damm@gmail.com>,
linux-pm@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 7/7] thermal: rcar: add Device Tree support
Date: Wed, 06 Feb 2013 16:36:27 +0800 [thread overview]
Message-ID: <1360139787.2982.43.camel@rzhang1-mobl4> (raw)
In-Reply-To: <87r4ktg7yh.wl%kuninori.morimoto.gx@renesas.com>
On Wed, 2013-02-06 at 00:30 -0800, Kuninori Morimoto wrote:
> Hi Zhang
>
> Thank you for checking patch
>
> > > +static const struct of_device_id rcar_thermal_dt_ids[] __devinitconst = {
> > > + { .compatible = "renesas,rcar-thermal", },
> > > + {},
> > > +};
> > > +MODULE_DEVICE_TABLE(of, rcar_thermal_dt_ids);
> > > +
> > you do not need
> > #ifdef CONFIG_OF
> > here?
>
> I didn't get any compile error here with/without CONFIG_OF.
> Of course I can add it if you want.
>
I checked some other drivers, some use #ifdef while some not.
I'm okay with this.
patch applied to thermal -next.
thanks,
rui
> Best regards
> ---
> Kuninori Morimoto
next prev parent reply other threads:[~2013-02-06 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 9:02 [PATCH 0/7] thermal: rcar: add interrupt and DT support Kuninori Morimoto
2013-01-31 9:02 ` [PATCH 1/7] thermal: rcar: use parenthesis on macro Kuninori Morimoto
2013-01-31 9:03 ` [PATCH 2/7] thermal: rcar: enable CPCTL to use hardware TSC deciding Kuninori Morimoto
2013-01-31 9:03 ` [PATCH 3/7] thermal: rcar: use mutex lock instead of spin lock Kuninori Morimoto
2013-01-31 9:03 ` [PATCH 4/7] thermal: rcar: multi channel support Kuninori Morimoto
2013-01-31 9:03 ` [PATCH 5/7] thermal: rcar: add read/write functions for common/priv data Kuninori Morimoto
2013-01-31 9:04 ` [PATCH 6/7] thermal: rcar: add interrupt support Kuninori Morimoto
2013-01-31 9:05 ` [PATCH 7/7] thermal: rcar: add Device Tree support Kuninori Morimoto
2013-02-06 5:37 ` Zhang Rui
2013-02-06 8:30 ` Kuninori Morimoto
2013-02-06 8:36 ` Zhang Rui [this message]
2013-02-06 8:37 ` Kuninori Morimoto
2013-01-31 9:26 ` [PATCH 8/7] thermal: rcar: remove machine_power_off() from rcar_thermal_notify() Kuninori Morimoto
2013-02-06 5:48 ` [PATCH 0/7] thermal: rcar: add interrupt and DT support Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360139787.2982.43.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox