From: Zhang Rui <rui.zhang@intel.com>
To: Richard Guy Briggs <rbriggs@redhat.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: return an error on failure to register thermal class
Date: Tue, 19 Feb 2013 23:48:56 +0800 [thread overview]
Message-ID: <1361288936.2323.31.camel@rzhang1-mobl4> (raw)
In-Reply-To: <1360697984-19960-1-git-send-email-rbriggs@redhat.com>
On Tue, 2013-02-12 at 14:39 -0500, Richard Guy Briggs wrote:
> The return code from the registration of the thermal class is used to
> unallocate resources, but this failure isn't passed back to the caller of
> thermal_init. Return this failure back to the caller.
>
> This bug was introduced in changeset 4cb18728 which overwrote the return code
> when the variable was re-used to catch the return code of the registration of
> the genetlink thermal socket family.
>
> Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
applied to thermal -next.
thanks,
rui
> ---
> drivers/thermal/thermal_sys.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 8c8ce80..bfbf9fb 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -1807,6 +1807,7 @@ static int __init thermal_init(void)
> idr_destroy(&thermal_cdev_idr);
> mutex_destroy(&thermal_idr_lock);
> mutex_destroy(&thermal_list_lock);
> + return result;
> }
> result = genetlink_init();
> return result;
prev parent reply other threads:[~2013-02-19 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 19:39 [PATCH] thermal: return an error on failure to register thermal class Richard Guy Briggs
2013-02-19 15:48 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361288936.2323.31.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rbriggs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).