From: Zhang Rui <rui.zhang@intel.com>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning
Date: Mon, 11 Mar 2013 22:24:28 +0800 [thread overview]
Message-ID: <1363011868.2291.74.camel@rzhang1-mobl4> (raw)
In-Reply-To: <1361886162-9387-1-git-send-email-laurent.navet@gmail.com>
On Tue, 2013-02-26 at 14:42 +0100, Laurent Navet wrote:
> - WARNING: Avoid CamelCase: <maskPtr>
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/thermal/cpu_cooling.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 836828e..47b7d32 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -175,8 +175,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> unsigned long cooling_state)
> {
> unsigned int cpuid, clip_freq;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> - unsigned int cpu = cpumask_any(maskPtr);
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> + unsigned int cpu = cpumask_any(mask);
>
>
> /* Check if the old cooling action is same as new cooling action */
> @@ -191,7 +191,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> cpufreq_device->cpufreq_val = clip_freq;
> notify_device = cpufreq_device;
>
> - for_each_cpu(cpuid, maskPtr) {
> + for_each_cpu(cpuid, mask) {
> if (is_cpufreq_valid(cpuid))
> cpufreq_update_policy(cpuid);
> }
why not fix the code in cpufreq_get_max_state() as well, in one patch?
thanks,
rui
next prev parent reply other threads:[~2013-03-11 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 13:42 [PATCH] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
2013-03-11 14:24 ` Zhang Rui [this message]
2013-03-11 19:42 ` Laurent Navet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363011868.2291.74.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=laurent.navet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).