* [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning
@ 2013-03-12 10:47 Laurent Navet
2013-03-25 8:08 ` Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Navet @ 2013-03-12 10:47 UTC (permalink / raw)
To: rui.zhang; +Cc: linux-pm, linux-kernel, Laurent Navet
- WARNING: Avoid CamelCase: <maskPtr>
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/thermal/cpu_cooling.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 8dc44cb..be2e6b0 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -168,8 +168,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
unsigned long cooling_state)
{
unsigned int cpuid, clip_freq;
- struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
- unsigned int cpu = cpumask_any(maskPtr);
+ struct cpumask *mask = &cpufreq_device->allowed_cpus;
+ unsigned int cpu = cpumask_any(mask);
/* Check if the old cooling action is same as new cooling action */
@@ -184,7 +184,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
cpufreq_device->cpufreq_val = clip_freq;
notify_device = cpufreq_device;
- for_each_cpu(cpuid, maskPtr) {
+ for_each_cpu(cpuid, mask) {
if (is_cpufreq_valid(cpuid))
cpufreq_update_policy(cpuid);
}
@@ -235,13 +235,13 @@ static int cpufreq_get_max_state(struct thermal_cooling_device *cdev,
unsigned long *state)
{
struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;
- struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
+ struct cpumask *mask = &cpufreq_device->allowed_cpus;
unsigned int cpu;
struct cpufreq_frequency_table *table;
unsigned long count = 0;
int i = 0;
- cpu = cpumask_any(maskPtr);
+ cpu = cpumask_any(mask);
table = cpufreq_frequency_get_table(cpu);
if (!table) {
*state = 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning
2013-03-12 10:47 [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
@ 2013-03-25 8:08 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2013-03-25 8:08 UTC (permalink / raw)
To: Laurent Navet; +Cc: linux-pm, linux-kernel
On Tue, 2013-03-12 at 11:47 +0100, Laurent Navet wrote:
> - WARNING: Avoid CamelCase: <maskPtr>
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
applied to thermal -next.
thanks,
rui
> ---
> drivers/thermal/cpu_cooling.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 8dc44cb..be2e6b0 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -168,8 +168,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> unsigned long cooling_state)
> {
> unsigned int cpuid, clip_freq;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> - unsigned int cpu = cpumask_any(maskPtr);
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> + unsigned int cpu = cpumask_any(mask);
>
>
> /* Check if the old cooling action is same as new cooling action */
> @@ -184,7 +184,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> cpufreq_device->cpufreq_val = clip_freq;
> notify_device = cpufreq_device;
>
> - for_each_cpu(cpuid, maskPtr) {
> + for_each_cpu(cpuid, mask) {
> if (is_cpufreq_valid(cpuid))
> cpufreq_update_policy(cpuid);
> }
> @@ -235,13 +235,13 @@ static int cpufreq_get_max_state(struct thermal_cooling_device *cdev,
> unsigned long *state)
> {
> struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> unsigned int cpu;
> struct cpufreq_frequency_table *table;
> unsigned long count = 0;
> int i = 0;
>
> - cpu = cpumask_any(maskPtr);
> + cpu = cpumask_any(mask);
> table = cpufreq_frequency_get_table(cpu);
> if (!table) {
> *state = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12 10:47 [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
2013-03-25 8:08 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).