Re: [PATCH V3 0/2] Thermal: cpufreq cooling fix

Re: [PATCH V3 0/2] Thermal: cpufreq cooling fix

[amit daniel kachhap]

Hi Rui,

For both the patches,
Acked by: Amit Daniel kachhap <amit.daniel@samsung.com>

Thanks,
Amit Daniel

On Fri, Mar 15, 2013 at 4:37 PM, AMIT DANIEL KACHHAP
<amit.daniel@samsung.com> wrote:
>
>
> ------- Original Message -------
> Sender : Zhang Rui<rui.zhang@intel.com>
> Date   : Mar 12, 2013 00:33 (GMT+09:00)
> Title  : [PATCH V3 0/2] Thermal: cpufreq cooling fix
>
> cpufreq cooling uses different frequencies as different cooling states.
>
> But the per_cpu cpufreq_frequency_table may contain duplicate,
> invalid entries, and it may be in either ascending or descending order.
> And currently, code for parsing the per_cpu cpufreq_frequency_table
> is used in several places and inconsistent.
>
> To fix this,
> New code is introduce in Patch 1/2, which contains the logic
> of parsing per_cpu cpufreq_frequency_table, and this piece of
> code can be used to:
> 1. get the maximum cooling states
> 2. translate cpu frequency to cooling state
> 3. translate cooling state to cpu frequency
>
> Patch 2/2 converts exynos_thermal driver to use the new code
> introduced in Patch 1/2.
>
> History:
> V3: fix wrong return value of get_cpu_frequency().
>     fix wrong return value of get_property() when property equals GET_MAXL.
>
> V2: remove cpu cooling table to avoid extra memory allocation.
>
> V1: introduce code to convert per_cpu cpufreq_frequency_table
>     to clean cpu cooling table (no invalid entry,
>     no duplicate entry, in descending order).
>
> I just run build test here. It would be great that some of you
> can test it on exynos.
> any comments?
>
> thanks,
> rui
> <p>&nbsp;</p><p>&nbsp;</p>

Re: [PATCH V3 0/2] Thermal: cpufreq cooling fix

[Zhang Rui]

Hi, Amit,

On Fri, 2013-03-15 at 16:44 +0530, amit daniel kachhap wrote:
> Hi Rui,
> 
> For both the patches,
> Acked by: Amit Daniel kachhap <amit.daniel@samsung.com>
> 
thanks. Do you have a chance to test these patches?

-rui

> Thanks,
> Amit Daniel
> 
> On Fri, Mar 15, 2013 at 4:37 PM, AMIT DANIEL KACHHAP
> <amit.daniel@samsung.com> wrote:
> >
> >
> > ------- Original Message -------
> > Sender : Zhang Rui<rui.zhang@intel.com>
> > Date   : Mar 12, 2013 00:33 (GMT+09:00)
> > Title  : [PATCH V3 0/2] Thermal: cpufreq cooling fix
> >
> > cpufreq cooling uses different frequencies as different cooling states.
> >
> > But the per_cpu cpufreq_frequency_table may contain duplicate,
> > invalid entries, and it may be in either ascending or descending order.
> > And currently, code for parsing the per_cpu cpufreq_frequency_table
> > is used in several places and inconsistent.
> >
> > To fix this,
> > New code is introduce in Patch 1/2, which contains the logic
> > of parsing per_cpu cpufreq_frequency_table, and this piece of
> > code can be used to:
> > 1. get the maximum cooling states
> > 2. translate cpu frequency to cooling state
> > 3. translate cooling state to cpu frequency
> >
> > Patch 2/2 converts exynos_thermal driver to use the new code
> > introduced in Patch 1/2.
> >
> > History:
> > V3: fix wrong return value of get_cpu_frequency().
> >     fix wrong return value of get_property() when property equals GET_MAXL.
> >
> > V2: remove cpu cooling table to avoid extra memory allocation.
> >
> > V1: introduce code to convert per_cpu cpufreq_frequency_table
> >     to clean cpu cooling table (no invalid entry,
> >     no duplicate entry, in descending order).
> >
> > I just run build test here. It would be great that some of you
> > can test it on exynos.
> > any comments?
> >
> > thanks,
> > rui
> > <p>&nbsp;</p><p>&nbsp;</p>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 0/2] Thermal: cpufreq cooling fix

[amit kachhap]

On Wed, Mar 20, 2013 at 6:55 AM, Zhang Rui <rui.zhang@intel.com> wrote:
> Hi, Amit,
>
> On Fri, 2013-03-15 at 16:44 +0530, amit daniel kachhap wrote:
>> Hi Rui,
>>
>> For both the patches,
>> Acked by: Amit Daniel kachhap <amit.daniel@samsung.com>
>>
> thanks. Do you have a chance to test these patches?
yes I tested them and they are fine.
Feel free to add,
Tested by: Amit Daniel kachhap <amit.daniel@samsung.com>

Thanks,
Amit Daniel
>
> -rui
>
>> Thanks,
>> Amit Daniel
>>
>> On Fri, Mar 15, 2013 at 4:37 PM, AMIT DANIEL KACHHAP
>> <amit.daniel@samsung.com> wrote:
>> >
>> >
>> > ------- Original Message -------
>> > Sender : Zhang Rui<rui.zhang@intel.com>
>> > Date   : Mar 12, 2013 00:33 (GMT+09:00)
>> > Title  : [PATCH V3 0/2] Thermal: cpufreq cooling fix
>> >
>> > cpufreq cooling uses different frequencies as different cooling states.
>> >
>> > But the per_cpu cpufreq_frequency_table may contain duplicate,
>> > invalid entries, and it may be in either ascending or descending order.
>> > And currently, code for parsing the per_cpu cpufreq_frequency_table
>> > is used in several places and inconsistent.
>> >
>> > To fix this,
>> > New code is introduce in Patch 1/2, which contains the logic
>> > of parsing per_cpu cpufreq_frequency_table, and this piece of
>> > code can be used to:
>> > 1. get the maximum cooling states
>> > 2. translate cpu frequency to cooling state
>> > 3. translate cooling state to cpu frequency
>> >
>> > Patch 2/2 converts exynos_thermal driver to use the new code
>> > introduced in Patch 1/2.
>> >
>> > History:
>> > V3: fix wrong return value of get_cpu_frequency().
>> >     fix wrong return value of get_property() when property equals GET_MAXL.
>> >
>> > V2: remove cpu cooling table to avoid extra memory allocation.
>> >
>> > V1: introduce code to convert per_cpu cpufreq_frequency_table
>> >     to clean cpu cooling table (no invalid entry,
>> >     no duplicate entry, in descending order).
>> >
>> > I just run build test here. It would be great that some of you
>> > can test it on exynos.
>> > any comments?
>> >
>> > thanks,
>> > rui
>> > <p>&nbsp;</p><p>&nbsp;</p>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

[PATCH V3 0/2] Thermal: cpufreq cooling fix

[Zhang Rui]

cpufreq cooling uses different frequencies as different cooling states.

But the per_cpu cpufreq_frequency_table may contain duplicate,
invalid entries, and it may be in either ascending or descending order.
And currently, code for parsing the per_cpu cpufreq_frequency_table
is used in several places and inconsistent.

To fix this,
New code is introduce in Patch 1/2, which contains the logic
of parsing per_cpu cpufreq_frequency_table, and this piece of
code can be used to:
1. get the maximum cooling states
2. translate cpu frequency to cooling state
3. translate cooling state to cpu frequency

Patch 2/2 converts exynos_thermal driver to use the new code
introduced in Patch 1/2.

History:
V3: fix wrong return value of get_cpu_frequency().
    fix wrong return value of get_property() when property equals GET_MAXL.

V2: remove cpu cooling table to avoid extra memory allocation.

V1: introduce code to convert per_cpu cpufreq_frequency_table
    to clean cpu cooling table (no invalid entry,
    no duplicate entry, in descending order).

I just run build test here. It would be great that some of you
can test it on exynos.
any comments?

thanks,
rui