From: Zhang Rui <rui.zhang@intel.com>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning
Date: Mon, 25 Mar 2013 16:08:33 +0800 [thread overview]
Message-ID: <1364198913.2465.40.camel@rzhang1-mobl4> (raw)
In-Reply-To: <1363085270-22886-1-git-send-email-laurent.navet@gmail.com>
On Tue, 2013-03-12 at 11:47 +0100, Laurent Navet wrote:
> - WARNING: Avoid CamelCase: <maskPtr>
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
applied to thermal -next.
thanks,
rui
> ---
> drivers/thermal/cpu_cooling.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 8dc44cb..be2e6b0 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -168,8 +168,8 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> unsigned long cooling_state)
> {
> unsigned int cpuid, clip_freq;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> - unsigned int cpu = cpumask_any(maskPtr);
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> + unsigned int cpu = cpumask_any(mask);
>
>
> /* Check if the old cooling action is same as new cooling action */
> @@ -184,7 +184,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
> cpufreq_device->cpufreq_val = clip_freq;
> notify_device = cpufreq_device;
>
> - for_each_cpu(cpuid, maskPtr) {
> + for_each_cpu(cpuid, mask) {
> if (is_cpufreq_valid(cpuid))
> cpufreq_update_policy(cpuid);
> }
> @@ -235,13 +235,13 @@ static int cpufreq_get_max_state(struct thermal_cooling_device *cdev,
> unsigned long *state)
> {
> struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;
> - struct cpumask *maskPtr = &cpufreq_device->allowed_cpus;
> + struct cpumask *mask = &cpufreq_device->allowed_cpus;
> unsigned int cpu;
> struct cpufreq_frequency_table *table;
> unsigned long count = 0;
> int i = 0;
>
> - cpu = cpumask_any(maskPtr);
> + cpu = cpumask_any(mask);
> table = cpufreq_frequency_get_table(cpu);
> if (!table) {
> *state = 0;
prev parent reply other threads:[~2013-03-25 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 10:47 [PATCH V2] drivers: thermal: cpu_cooling: fix checkpatch warning Laurent Navet
2013-03-25 8:08 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364198913.2465.40.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=laurent.navet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).