[PATCH 1/1] thermal: add a warning for temperature emulation feature

[PATCH 1/1] thermal: add a warning for temperature emulation feature

[Eduardo Valentin]

Because this feature is for debuging purposes, it is highly
recommended to do not enable this on production systems.
This patch adds warnings for system integrators, so that
people are aware of this potential security issue.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
 Documentation/thermal/sysfs-api.txt |    4 ++++
 drivers/thermal/Kconfig             |    5 +++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
index a9abb84..0a7d6df 100644
--- a/Documentation/thermal/sysfs-api.txt
+++ b/Documentation/thermal/sysfs-api.txt
@@ -265,6 +265,10 @@ emul_temp
 	Unit: millidegree Celsius
 	WO, Optional
 
+	  WARNING: Be careful while enabling this option on production systems,
+	  because userland can easily disable the thermal policy by simply
+	  flooding this sysfs node with low temperature values.
+
 *****************************
 * Cooling device attributes *
 *****************************
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index a764f16..004e5f7 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -80,12 +80,17 @@ config CPU_THERMAL
 
 config THERMAL_EMULATION
 	bool "Thermal emulation mode support"
+	default false
 	help
 	  Enable this option to make a emul_temp sysfs node in thermal zone
 	  directory to support temperature emulation. With emulation sysfs node,
 	  user can manually input temperature and test the different trip
 	  threshold behaviour for simulation purpose.
 
+	  WARNING: Be careful while enabling this option on production systems,
+	  because userland can easily disable the thermal policy by simply
+	  flooding this sysfs node with low temperature values.
+
 config SPEAR_THERMAL
 	bool "SPEAr thermal sensor driver"
 	depends on PLAT_SPEAR
-- 
1.7.7.1.488.ge8e1c

Re: [PATCH 1/1] thermal: add a warning for temperature emulation feature

[Zhang Rui]

On Tue, 2013-03-26 at 17:38 -0400, Eduardo Valentin wrote:
> Because this feature is for debuging purposes, it is highly
> recommended to do not enable this on production systems.
> This patch adds warnings for system integrators, so that
> people are aware of this potential security issue.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
>  Documentation/thermal/sysfs-api.txt |    4 ++++
>  drivers/thermal/Kconfig             |    5 +++++
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
> index a9abb84..0a7d6df 100644
> --- a/Documentation/thermal/sysfs-api.txt
> +++ b/Documentation/thermal/sysfs-api.txt
> @@ -265,6 +265,10 @@ emul_temp
>  	Unit: millidegree Celsius
>  	WO, Optional
>  
> +	  WARNING: Be careful while enabling this option on production systems,
> +	  because userland can easily disable the thermal policy by simply
> +	  flooding this sysfs node with low temperature values.
> +
>  *****************************
>  * Cooling device attributes *
>  *****************************
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index a764f16..004e5f7 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -80,12 +80,17 @@ config CPU_THERMAL
>  
>  config THERMAL_EMULATION
>  	bool "Thermal emulation mode support"
> +	default false

we do not need this as any Kconfig option is set to 'n' by default.

Others seem okay to me and applied.

thanks,
rui
>  	help
>  	  Enable this option to make a emul_temp sysfs node in thermal zone
>  	  directory to support temperature emulation. With emulation sysfs node,
>  	  user can manually input temperature and test the different trip
>  	  threshold behaviour for simulation purpose.
>  
> +	  WARNING: Be careful while enabling this option on production systems,
> +	  because userland can easily disable the thermal policy by simply
> +	  flooding this sysfs node with low temperature values.
> +
>  config SPEAR_THERMAL
>  	bool "SPEAr thermal sensor driver"
>  	depends on PLAT_SPEAR

Re: [PATCH 1/1] thermal: add a warning for temperature emulation feature

[Eduardo Valentin]

On 02-04-2013 09:33, Zhang Rui wrote:
> On Tue, 2013-03-26 at 17:38 -0400, Eduardo Valentin wrote:
>> Because this feature is for debuging purposes, it is highly
>> recommended to do not enable this on production systems.
>> This patch adds warnings for system integrators, so that
>> people are aware of this potential security issue.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
>> ---
>>   Documentation/thermal/sysfs-api.txt |    4 ++++
>>   drivers/thermal/Kconfig             |    5 +++++
>>   2 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
>> index a9abb84..0a7d6df 100644
>> --- a/Documentation/thermal/sysfs-api.txt
>> +++ b/Documentation/thermal/sysfs-api.txt
>> @@ -265,6 +265,10 @@ emul_temp
>>   	Unit: millidegree Celsius
>>   	WO, Optional
>>
>> +	  WARNING: Be careful while enabling this option on production systems,
>> +	  because userland can easily disable the thermal policy by simply
>> +	  flooding this sysfs node with low temperature values.
>> +
>>   *****************************
>>   * Cooling device attributes *
>>   *****************************
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index a764f16..004e5f7 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -80,12 +80,17 @@ config CPU_THERMAL
>>
>>   config THERMAL_EMULATION
>>   	bool "Thermal emulation mode support"
>> +	default false
>
> we do not need this as any Kconfig option is set to 'n' by default.
>


Yeah, I know it is a NOP. But that was intentional, just make the warn 
shout aloud :-)

> Others seem okay to me and applied.

OK. Thanks.


>
> thanks,
> rui
>>   	help
>>   	  Enable this option to make a emul_temp sysfs node in thermal zone
>>   	  directory to support temperature emulation. With emulation sysfs node,
>>   	  user can manually input temperature and test the different trip
>>   	  threshold behaviour for simulation purpose.
>>
>> +	  WARNING: Be careful while enabling this option on production systems,
>> +	  because userland can easily disable the thermal policy by simply
>> +	  flooding this sysfs node with low temperature values.
>> +
>>   config SPEAR_THERMAL
>>   	bool "SPEAr thermal sensor driver"
>>   	depends on PLAT_SPEAR
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>